From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist. Date: Thu, 27 Mar 2014 14:34:41 -0700 Message-ID: <53349971.3000806@whitecape.org> References: <1395813123-2027-1-git-send-email-kenneth@whitecape.org> <20140326062123.GO26878@phenom.ffwll.local> <20140326160358.GA11367@bdvolkin-ubuntu-desktop> <20140326163820.GV26878@phenom.ffwll.local> <53331068.7090007@whitecape.org> <20140326182605.GA28133@bdvolkin-ubuntu-desktop> <20140327075721.GA26878@phenom.ffwll.local> <20140327155708.GA4690@bdvolkin-ubuntu-desktop> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0258348803==" Return-path: Received: from homiemail-a8.g.dreamhost.com (mailbigip.dreamhost.com [208.97.132.5]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BCF96E57C for ; Thu, 27 Mar 2014 14:33:57 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0258348803== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Gxd51kqbAt1Rhq8j08mnmCQ2fTF2AWqCu" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Gxd51kqbAt1Rhq8j08mnmCQ2fTF2AWqCu Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 03/27/2014 01:16 PM, Daniel Vetter wrote: > On Thu, Mar 27, 2014 at 4:57 PM, Volkin, Bradley D > wrote: >> On Thu, Mar 27, 2014 at 12:57:21AM -0700, Daniel Vetter wrote: >>> Another one that blows is igt/gen7_forcewake_mt. Not sure yet whether= it's >>> an issue with the test or the checker: >>> >>> https://bugs.freedesktop.org/show_bug.cgi?id=3D76670 >> >> For this one, the parser rejects an MI_STORE_REGISTER_MEM with the GGT= T bit >> set. We don't currently allow that, even from master. It sounds like t= here >> might be released versions of the ddx that do this as well. If that's = the >> case, or if there are other situations where tests, etc rely on being = able >> to do whatever they want when setting the I915_DISPATCH_SECURE flag, t= hen I >> think we might as well stop parsing secure batches and let them go thr= ough >> as before. >=20 > Well for the testcase I think we can just add the missing flag. If > there's indeed shipping userspace out there which is getting these > flags wrong then I think we need to silently upgrade them when copying > the cmds over to the 2nd batch. But I guess until that need is really > established we can hope we don't need this. > -Daniel Why are we parsing batches with I915_EXEC_SECURE at all? Secure batches are only issued from trusted code which is guaranteed to be running as root. I don't see any benefit to scanning those batches, and there's definitely overhead. I mean, sure, it may be reasonable in the short term as a way to test the command parser, but I certainly hope we don't *ship* that. --Ken --Gxd51kqbAt1Rhq8j08mnmCQ2fTF2AWqCu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTNJl1AAoJEFtb2gcdScw4p6cP/1dfLqhoClAQg3s1UuAPa9bK 2kcw3YMZ1RE0J5JKs7cP1tKHNTHfmXQJkx8NbS0hdcrbmUzYMclf3z4M64djP6Ly Fzm8ote4sE3U9hva2DW+AWZjLee/tUI197rOYZawaKB5aB1TghzZxjzBqsaeaXH6 9pOfsUPGJo4wKhoicB2QCSiSSYHeKt457+TsMe64bN1NwatGTs0WX0R/A1AjjW8p yeEwIfppla7nrjzHmJMc39aFdsLLPkkTmleN+3NBGLTnj7RSAf96iOP++F0VSr0n cd9N+tvhgucZcJSNMNpoqXfZFPfHscZuC4SyJM/wQwLK0STvNlCMw/deIaGQ9RrU QAbxHojMnXfW/fEOlrjOWjdxkgNVBMfubKWnspVxgYU3D8jcykT3G4IdWQoKbsd8 iqb2xFo8bB+SLAxS5GgGrChAWIG6ircz9cYr8zKhW7gjlIFwRe0YlXzC/qrNVf5P hTmI3trofsa07RpGahpPOhWkKX+lpk+2SCHz3ONGUdMDTWytthRzky9cG+v4yg7h yvK8rAcrUSjiSwPUdvYol/qX06mYNcrilRWtJaTrhUKJIg1dZUwZNPednMI7kbnZ vUpsRWvwKkKDhZHNA2id6bLq/bu5nFs+wAwmyHUsJtDEvosPsb/tq5GQrapKBvPc YeBAwAC/hVDPSPKUUv2b =hA0K -----END PGP SIGNATURE----- --Gxd51kqbAt1Rhq8j08mnmCQ2fTF2AWqCu-- --===============0258348803== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0258348803==--