From: Kenneth Graunke <kenneth@whitecape.org>
To: bradley.d.volkin@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915: Refactor cmd parser checks into a function
Date: Thu, 27 Mar 2014 14:49:47 -0700 [thread overview]
Message-ID: <53349CFB.20404@whitecape.org> (raw)
In-Reply-To: <1395945820-20376-3-git-send-email-bradley.d.volkin@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 474 bytes --]
On 03/27/2014 11:43 AM, bradley.d.volkin@intel.com wrote:
> From: Brad Volkin <bradley.d.volkin@intel.com>
>
> This brings the code a little more in line with kernel coding style.
>
> Signed-off-by: Brad Volkin <bradley.d.volkin@intel.com>
> ---
> drivers/gpu/drm/i915/i915_cmd_parser.c | 136 +++++++++++++++++----------------
> 1 file changed, 71 insertions(+), 65 deletions(-)
I like the refactor.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-03-27 21:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 18:43 [PATCH 0/3] Fix up cmd parser OACONTROL handling + refactorings bradley.d.volkin
2014-03-27 18:43 ` [PATCH 1/3] drm/i915: BUG_ON() when cmd/reg tables are not sorted bradley.d.volkin
2014-03-27 21:47 ` Kenneth Graunke
2014-03-27 23:56 ` Volkin, Bradley D
2014-04-02 9:11 ` Jani Nikula
2014-04-02 9:35 ` Daniel Vetter
2014-03-27 18:43 ` [PATCH 2/3] drm/i915: Refactor cmd parser checks into a function bradley.d.volkin
2014-03-27 21:49 ` Kenneth Graunke [this message]
2014-04-02 9:14 ` Jani Nikula
2014-03-27 18:43 ` [PATCH 3/3] drm/i915: Track OACONTROL register enable/disable during parsing bradley.d.volkin
2014-03-27 21:58 ` Kenneth Graunke
2014-03-28 0:06 ` Volkin, Bradley D
2014-03-28 7:51 ` Daniel Vetter
2014-03-28 17:21 ` [PATCH v2 " bradley.d.volkin
2014-03-28 17:37 ` Kenneth Graunke
2014-04-02 9:35 ` Jani Nikula
2014-04-10 6:07 ` Zhenyu Wang
2014-04-10 6:43 ` Daniel Vetter
2014-04-10 7:51 ` Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53349CFB.20404@whitecape.org \
--to=kenneth@whitecape.org \
--cc=bradley.d.volkin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox