From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH] drm/i915: Add OACONTROL to the command parser register whitelist. Date: Thu, 27 Mar 2014 16:22:44 -0700 Message-ID: <5334B2C4.5000702@whitecape.org> References: <1395813123-2027-1-git-send-email-kenneth@whitecape.org> <20140326062123.GO26878@phenom.ffwll.local> <20140326160358.GA11367@bdvolkin-ubuntu-desktop> <20140326163820.GV26878@phenom.ffwll.local> <53331068.7090007@whitecape.org> <20140326182605.GA28133@bdvolkin-ubuntu-desktop> <20140327075721.GA26878@phenom.ffwll.local> <20140327155708.GA4690@bdvolkin-ubuntu-desktop> <53349971.3000806@whitecape.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1477493412==" Return-path: Received: from homiemail-a7.g.dreamhost.com (caiajhbdcahe.dreamhost.com [208.97.132.74]) by gabe.freedesktop.org (Postfix) with ESMTP id 935766EB42 for ; Thu, 27 Mar 2014 16:22:03 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1477493412== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AnRI4Cs9dO34hEDCTrvV8LGnbX9MDO9Nm" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AnRI4Cs9dO34hEDCTrvV8LGnbX9MDO9Nm Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 03/27/2014 03:44 PM, Daniel Vetter wrote: > On Thu, Mar 27, 2014 at 10:34 PM, Kenneth Graunke wrote: >> Why are we parsing batches with I915_EXEC_SECURE at all? Secure batch= es >> are only issued from trusted code which is guaranteed to be running as= >> root. I don't see any benefit to scanning those batches, and there's >> definitely overhead. >> >> I mean, sure, it may be reasonable in the short term as a way to test >> the command parser, but I certainly hope we don't *ship* that. >=20 > Everyone runs X as root, but I kinda want X to also be able to run as > non-root. The cmd parser has a special list of drm master register > lists which should allow this, but if we just bypass the cmd parser > for all normal X installs we'll have 0 test coverage on this. Which > means broken like hell. >=20 > Hence I actually intend to ship this, yes. Chris doesn't like it either= really. > -Daniel Seriously? Hurt performance on every user's system just so you can test things? That a classic case of the tail wagging the dog. Why not make a i915.enable_cmd_parser=3D2 value which enables it all the time and use that when running igt? Clearly being able to test this is valuable, but enabling it universally is *not* OK. --AnRI4Cs9dO34hEDCTrvV8LGnbX9MDO9Nm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTNLLJAAoJEFtb2gcdScw41SMP/RGacGus5N0NPQTqWWWN0BA3 KkZLir1XlJfVOG0wI2Rn58rhUUGUaZn9VXcXVNCsfqXt1sBL0aPvsgNu0yZQS6n1 q6sdfIGJ99H/MstLqWPuavvo2pt2VuVqu5Lg7aF8gDE44hiCPlmrw8iQsSjTFeyl Lt+XlyIdwx79jfc7mGucPJX6PVnYS4ZDkov19CZsUPB9q+m4s9pzc+/hORlzCfpb 4Lfny+24MVI1xPmp6fEuBqTx8J/qhbti/yNjc6yhKuw7xaY2IAPMGciyvUexRJB2 mfqmBxuop3WfD9sGA/SYV19thvn748jhKoRO7VMoseNR91RxTdiGr5YRTcp6yKVx AZHqH6huZPlPq/MkTM9cfWuFULB0uz2A9I3vLKy4oQ+9vJoWF7PF6mpphP4080FN 7Y0N1VOebrOxT+OXB1mA2OtIK0SHlTqH64worD/M9sFRG0pfVIPYHjTZ0jO5vvOt Mq/CjvNN74Cw11wTF3grgbylzwj7JZrFXKy2PoTcTW9a53QafdyvDdvKZb28nE9Y g4rus+nspeA3yhGsm9kz+Lt36NrmZr7wOuPo7Ra/HBNq4yNmfuxT3cHgmDYTFzIT jcqiywQ5j0yS6bN9E7fTWrX/bm/u7ePdgi+Pg/bPhd8SPRqorB6Pta3VEQj/NTKU 4xl2a0xdd8OJJ2CJXzs6 =sCEx -----END PGP SIGNATURE----- --AnRI4Cs9dO34hEDCTrvV8LGnbX9MDO9Nm-- --===============1477493412== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1477493412==--