From mboxrd@z Thu Jan  1 00:00:00 1970
From: Deepak S <deepak.s@linux.intel.com>
Subject: Re: [PATCH v5] drm/i915/vlv: WA for Turbo and RC6 to
 work together.
Date: Sun, 30 Mar 2014 11:57:52 +0530
Message-ID: <5337B968.3070703@linux.intel.com>
References: <1394895204-13581-1-git-send-email-deepak.s@linux.intel.com>
 <1395902101-9869-1-git-send-email-deepak.s@linux.intel.com>
 <20140328125348.GR21652@intel.com>
 <20140328130622.GB5582@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 443BC6E01C
 for <intel-gfx@lists.freedesktop.org>; Sat, 29 Mar 2014 23:27:55 -0700 (PDT)
In-Reply-To: <20140328130622.GB5582@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, =?ISO-8859-1?Q?Ville_Syrj=E4?= =?ISO-8859-1?Q?l=E4?= <ville.syrjala@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org


On Friday 28 March 2014 06:36 PM, Chris Wilson wrote:
> On Fri, Mar 28, 2014 at 02:53:48PM +0200, Ville Syrj=E4l=E4 wrote:
>> On Thu, Mar 27, 2014 at 12:05:01PM +0530, deepak.s@linux.intel.com wrote:
>>> @@ -1403,6 +1411,13 @@ typedef struct drm_i915_private {
>>>   	/* gen6+ rps state */
>>>   	struct intel_gen6_power_mgmt rps;
>>>   =

>>> +	/* rps wa up ei calculation */
>>> +	struct intel_rps_ei_calc rps_up_ei;
>>> +
>>> +	/* rps wa down ei calculation */
>>> +	struct intel_rps_ei_calc rps_down_ei;
> I could have sworn there was a field for holding all the interesting rps
> state together.
> -Chris
>
Hi Chris,

Earlier i was using the rps structure to hold the wa rps state, but there w=
as not of duplicated code to avoid that i created a separate structure.
We can still re-factor and use rps structure to hold the wa state. Let me k=
now if we need to created a separate patch to re-factor or add to the WA pa=
tch itself.

I a thinking of adding a new patch on top this.

Thanks