From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Antti_Koskip=E4=E4?= Subject: Re: [PATCH i-g-t 5/7] kms_cursor_crc: Add reference software rendering Date: Wed, 02 Apr 2014 14:27:40 +0300 Message-ID: <533BF42C.7030106@linux.intel.com> References: <1396436790-14313-1-git-send-email-antti.koskipaa@linux.intel.com> <1396436790-14313-6-git-send-email-antti.koskipaa@linux.intel.com> <20140402112159.GO21652@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 0BD3A6EA7A for ; Wed, 2 Apr 2014 04:27:38 -0700 (PDT) In-Reply-To: <20140402112159.GO21652@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?ISO-8859-1?Q?Ville_Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 04/02/2014 02:21 PM, Ville Syrj=E4l=E4 wrote: > On Wed, Apr 02, 2014 at 02:06:28PM +0300, Antti Koskipaa wrote: > >> @@ -184,9 +192,6 @@ static void test_crc_offscreen(test_data_t *test_dat= a) >> do_test(test_data, left - (cursor_w+512), right + (cursor_w+512), top = , bottom ); >> do_test(test_data, left , right , top = - (cursor_h+512), bottom + (cursor_h+512)); >> do_test(test_data, left - (cursor_w+512), right + (cursor_w+512), top = - (cursor_h+512), bottom + (cursor_h+512)); >> - >> - /* go nuts */ >> - do_test(test_data, INT_MIN, INT_MAX, INT_MIN, INT_MAX); > = > Why are you dropping the go nuts test? We had an actual bug in the > driver that this managed to hit. We should keep this test to avoid > regressions. Link please. Cairo went nuts with that one, but if there is a case for the test, I'll work around Cairo to keep it. -- = - Antti