Re: [BUG] Cursor code broken

[Knut Petersen <Knut_Petersen@t-online.de>]

On 09.04.2014 17:19, Chris Wilson wrote:
> On Wed, Apr 09, 2014 at 03:59:29PM +0100, Chris Wilson wrote:
>> On Wed, Apr 09, 2014 at 03:37:35PM +0200, Daniel Vetter wrote:
>>> On Wed, Apr 09, 2014 at 08:16:30AM +0200, Knut Petersen wrote:
>>>> Hi Chris!
>>>>
>>>> The intel xorg driver cursor code is broken, at least on my system.
>>>> The last good commit is 3810cff42bca1badc5844002694a6f582c0f423.
>>> Hm, you mean
>>>
>>> commit 25ca8f136cef9e1bdf06967bf8e78c87b54ffce2
>>> Author: Chris Wilson <chris@chris-wilson.co.uk>
>>> Date:   Thu Mar 27 14:15:30 2014 +0000
>>>
>>>      sna: Support variable sized cursors
>>>
>>> Iirc Chris already fixed this in latest git.
>> Ah, no. This is a phys cursor artifact. Special hardware, extra special
>> code.
> Should be fixed with
>
> commit dba43d370b984e262f6fe5920b38b433f4bd392b
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Wed Apr 9 16:11:26 2014 +0100

Yes indeed. Thanks!

cu,
  Knut
>
>      sna: Use pwrite to update physical cursors
>      
>      Older hardware uses physical addresses for its cursor, which are
>      implemented by the kernel in an incoherent fashion. Maybe with stolen
>      support this would be different...
>      
>      Fixes regression on [845g, 945g] from
>      commit 25ca8f136cef9e1bdf06967bf8e78c87b54ffce2
>      Author: Chris Wilson <chris@chris-wilson.co.uk>
>      Date:   Thu Mar 27 14:15:30 2014 +0000
>      
>          sna: Support variable sized cursors
>      
>      Reported-by: Knut Petersen <Knut_Petersen@t-online.de>
>      Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
>
> It just so happens that the older hardware I tested on (845g and pnv)
> doesn't use physical cursors!
> -Chris
>