From mboxrd@z Thu Jan  1 00:00:00 1970
From: Knut Petersen <Knut_Petersen@t-online.de>
Subject: Re: [BUG] Cursor code broken
Date: Wed, 09 Apr 2014 19:02:05 +0200
Message-ID: <53457D0D.2040507@t-online.de>
References: <5344E5BE.6060907@t-online.de>
 <20140409133735.GV9262@phenom.ffwll.local>
 <20140409145929.GD4573@nuc-i3427.alporthouse.com>
 <20140409151919.GB14192@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mailout12.t-online.de (mailout12.t-online.de [194.25.134.22])
 by gabe.freedesktop.org (Postfix) with ESMTP id A815A6E0E4
 for <intel-gfx@lists.freedesktop.org>; Wed,  9 Apr 2014 10:11:12 -0700 (PDT)
In-Reply-To: <20140409151919.GB14192@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel@ffwll.ch>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On 09.04.2014 17:19, Chris Wilson wrote:
> On Wed, Apr 09, 2014 at 03:59:29PM +0100, Chris Wilson wrote:
>> On Wed, Apr 09, 2014 at 03:37:35PM +0200, Daniel Vetter wrote:
>>> On Wed, Apr 09, 2014 at 08:16:30AM +0200, Knut Petersen wrote:
>>>> Hi Chris!
>>>>
>>>> The intel xorg driver cursor code is broken, at least on my system.
>>>> The last good commit is 3810cff42bca1badc5844002694a6f582c0f423.
>>> Hm, you mean
>>>
>>> commit 25ca8f136cef9e1bdf06967bf8e78c87b54ffce2
>>> Author: Chris Wilson <chris@chris-wilson.co.uk>
>>> Date:   Thu Mar 27 14:15:30 2014 +0000
>>>
>>>      sna: Support variable sized cursors
>>>
>>> Iirc Chris already fixed this in latest git.
>> Ah, no. This is a phys cursor artifact. Special hardware, extra special
>> code.
> Should be fixed with
>
> commit dba43d370b984e262f6fe5920b38b433f4bd392b
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Wed Apr 9 16:11:26 2014 +0100

Yes indeed. Thanks!

cu,
  Knut
>
>      sna: Use pwrite to update physical cursors
>      
>      Older hardware uses physical addresses for its cursor, which are
>      implemented by the kernel in an incoherent fashion. Maybe with stolen
>      support this would be different...
>      
>      Fixes regression on [845g, 945g] from
>      commit 25ca8f136cef9e1bdf06967bf8e78c87b54ffce2
>      Author: Chris Wilson <chris@chris-wilson.co.uk>
>      Date:   Thu Mar 27 14:15:30 2014 +0000
>      
>          sna: Support variable sized cursors
>      
>      Reported-by: Knut Petersen <Knut_Petersen@t-online.de>
>      Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
>
> It just so happens that the older hardware I tested on (845g and pnv)
> doesn't use physical cursors!
> -Chris
>