Re: [PATCH 14/71] drm/i915/chv: Add early quirk for stolen

Daniel Vetter
2014-05-12T17:22:30Z

On Thu, May 08, 2014 at 06:10:45PM +0300, Jani Nikula wrote:
> On Thu, 08 May 2014, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Thu, May 08, 2014 at 05:32:21PM +0300, Jani Nikula wrote:
> >> On Wed, 09 Apr 2014, ville.syrjala@linux.intel.com wrote:
> >> > From: Daniel Vetter <daniel.vetter@ffwll.ch>
> >> >
> >> > Same as on other gen8 devices.
> >> >
> >> > Cc: Ingo Molnar <mingo@kernel.org>
> >> > Cc: H. Peter Anvin <hpa@zytor.com>
> >> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >> > ---
> >> > arch/x86/kernel/early-quirks.c | 3 ++-
> >> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >> >
> >> > diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> >> > index bc4a088..5758f5b 100644
> >> > --- a/arch/x86/kernel/early-quirks.c
> >> > +++ b/arch/x86/kernel/early-quirks.c
> >> > @@ -347,7 +347,8 @@ static struct pci_device_id intel_stolen_ids[] __initdata = {
> >> > INTEL_HSW_D_IDS(gen6_stolen_size),
> >> > INTEL_HSW_M_IDS(gen6_stolen_size),
> >> > INTEL_BDW_M_IDS(gen8_stolen_size),
> >> > - INTEL_BDW_D_IDS(gen8_stolen_size)
> >> > + INTEL_BDW_D_IDS(gen8_stolen_size),
> >> > + INTEL_CHV_PCI_IDS(gen8_stolen_size)
> >>
> >> Needs refresh after the update to the #define.
> >
> > This patch is actually wrong. We need CHV specific stolen size detection
> > here. And in fact we get it as part of patch 34/71. I'll go and split
> > that up into i915 and x86 specific parts and pretend that this patch
> > never existed.
>
> Right, I'm actually looking at 34 now.

Ok, I'll ignore this one here.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch