From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kumar, Shobhit" <shobhit.kumar@intel.com>
Subject: Re: [PATCH v3] drm/i915: Add parsing support for new
 MIPI blocks in VBT
Date: Mon, 14 Apr 2014 13:24:43 +0530
Message-ID: <534B9443.7020609@intel.com>
References: <1392895001-26055-3-git-send-email-shobhit.kumar@intel.com>
 <1397453434-9427-1-git-send-email-shobhit.kumar@intel.com>
 <20140414070251.GB8068@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id E7E946E718
 for <intel-gfx@lists.freedesktop.org>; Mon, 14 Apr 2014 00:54:46 -0700 (PDT)
In-Reply-To: <20140414070251.GB8068@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Jani Nikula <jani.nikula@intel.com>, Daniel Vetter <daniel.vetter@intel.com>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On 4/14/2014 12:32 PM, Daniel Vetter wrote:
> On Mon, Apr 14, 2014 at 11:00:34AM +0530, Shobhit Kumar wrote:
>> The parser extracts the config block(#52) and sequence(#53) data
>> and store in private data structures.
>>
>> v2: Address review comments by Jani
>>      - adjust code for the structure changes for bdb_mipi_config
>>      - add boundry and buffer overflow checks as suggested
>>      - use kmemdup instead of kmalloc and memcpy
>>
>> v3: More strict check while parsing VBT
>>      - Ensure that at anytime we do not go beyond sequence block
>>        while parsing
>>      - On unknown element fail the whole parsing
>>
>> v4: Style changes and spell check mostly as suggested by Jani
>>
>> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
>> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> I didn't spot Jani's r-b tag in earlier mails, was that done off-list?

Yeah, was reviewed along with the other DSI patchset you merged, sorry 
about that. But then some patches needed internal review while they were 
being approved for up-streaming to save time. And this one was related 
to the other panel driver patches which I published today so got stuck 
with them. Sorry about that.

Regards
Shobhit