From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Powalowski Subject: Re: 3.14 issue with i810 graphic card bisected Date: Sat, 19 Apr 2014 21:00:11 +0200 Message-ID: <5352C7BB.8040009@googlemail.com> References: <533D01BD.1010200@googlemail.com> <20140418203825.GK23576@htj.dyndns.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1005401894==" Return-path: Received: from mail-ee0-f45.google.com (mail-ee0-f45.google.com [74.125.83.45]) by gabe.freedesktop.org (Postfix) with ESMTP id A5F386E6E8 for ; Sat, 19 Apr 2014 12:00:17 -0700 (PDT) Received: by mail-ee0-f45.google.com with SMTP id d17so2563129eek.4 for ; Sat, 19 Apr 2014 12:00:16 -0700 (PDT) In-Reply-To: <20140418203825.GK23576@htj.dyndns.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tejun Heo Cc: davej@redhat.com, Daniel Vetter , =?ISO-8859-1?Q?Thomas_B=E4chler?= , intel-gfx , gregkh@linuxfoundation.org List-Id: intel-gfx@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1005401894== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="64OjO0TTl6hkIkHXhwRnjSUDMQdIEj1Og" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --64OjO0TTl6hkIkHXhwRnjSUDMQdIEj1Og Content-Type: multipart/mixed; boundary="------------020104090402010301050906" This is a multi-part message in MIME format. --------------020104090402010301050906 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Am 18.04.2014 22:38, schrieb Tejun Heo: > Hello, > > Sorry about the long delay. > > On Thu, Apr 03, 2014 at 08:37:49AM +0200, Tobias Powalowski wrote: >> Hi, >> I bisected a X startup crash due to new 3.14 kernel: >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit= /fs/kernfs/file.c?id=3D9b2db6e1894577d48f4e290381bac6e573593838 >> It's an old intel 810 graphics card which got broken. >> dmesg and xorg.log attached. > Hmm... I'm stumped. The patch shouldn't cause any visible difference > to the userland. I went over it a couple more times and still can't > see how this would make any difference. Can you please do the > followings? > > * Repeat the test on v3.14 with only the patch reverted. If it makes > the problem go away reliably, > > * strace X startup on v3.14 and v3.14 sans the offending patch. > > Thanks! > Hi shortened the patch, indeed only the 5 lines are the error source. Patch attached. greetings tpowa --=20 Tobias Powalowski Archlinux Developer & Package Maintainer (tpowa) http://www.archlinux.org tpowa@archlinux.org --------------020104090402010301050906 Content-Type: text/x-patch; name="fix-i810-short.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="fix-i810-short.patch" --- linux-3.14/fs/kernfs/file.c.orig 2014-03-31 05:40:15.000000000 +0200 +++ linux-3.14/fs/kernfs/file.c 2014-04-19 08:22:11.754042780 +0200 @@ -475,7 +468,10 @@ goto out_unlock; =20 ops =3D kernfs_ops(of->kn); + if (ops->mmap) + rc =3D ops->mmap(of, vma); + if (rc) + goto out_put; - rc =3D ops->mmap(of, vma); =20 /* * PowerPC's pci_mmap of legacy_mem uses shmem_zero_setup() --------------020104090402010301050906-- --64OjO0TTl6hkIkHXhwRnjSUDMQdIEj1Og Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTUse+AAoJEHcd9mJ+32gfXwUH/AzwUDtW4RtsuXMFbTJF+1Ps fdwo4Kr+5W2Z3n8xgjjkGApZs+2K+FHkDZU3lKdBZSeVBlFBdNhgsqbSH+QMa2Ct Y+sS9++CZL3/TSzbsWkrQ8PLQ0WpoZ+pliJO7hPTYkrxynBv79iJW2ulkCpqjyC9 HrDsZlokNrJ1wyuFKGjhcdNBgfXOi7L1boVvSmn7Cz470ayQKAfrMz5moWaw51Ug /WqlGyEkp0vVm5WiQCVE9F3PKqmmbCttGq28r4Z7HC0b0weOSIZg+QngZ4m4fzKJ 9YspHwopmEeQSJyG07xmPswgjp1qAzgy+BjB05NKAwUu/TSURNn2Lmb/dBXNQUY= =KY9h -----END PGP SIGNATURE----- --64OjO0TTl6hkIkHXhwRnjSUDMQdIEj1Og-- --===============1005401894== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1005401894==--