Re: [PATCH 00/14] drm-intel-collector - update

Daniel Vetter
2014-04-25T10:07:53Z

On Fri, Apr 25, 2014 at 10:24:45AM +0100, Chris Wilson wrote:
> On Fri, Apr 25, 2014 at 11:04:22AM +0200, Daniel Vetter wrote:
> > > Patch drm/i915: Upgrade execbuffer fail after resume failure to EIO - Reviewer:
> >
> > Do we still need this on top of what I've merged. Chris?
>
> Yes. We can still start the device without initializing all of the
> available rings and so hit this before we fail with an EIO.

Hm, so we'd need to adjust the commit message a bit since with

commit 5582e8c3c49150c0e7398688b5ed167d6c3d44fd
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed Apr 9 09:19:41 2014 +0100

drm/i915: Preserve ring buffers objects across resume

this is just a driver load issue and no longer a resume issue. Or do I
miss something else?

Or should we frob the ring init some more and simply leave the ring->obj
hanging around, eat the -EIO and wedge the gpu?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch