From mboxrd@z Thu Jan  1 00:00:00 1970
From: Knut Petersen <Knut_Petersen@t-online.de>
Subject: Re: [PATCH] drm/i915: Use the first mode if there is no
 preferred mode in the EDID
Date: Wed, 14 May 2014 07:35:23 +0200
Message-ID: <5373009B.50800@t-online.de>
References: <1399993657-4544-1-git-send-email-chris@chris-wilson.co.uk>
 <20140513155012.GR7239@nuc-i3427.alporthouse.com>
 <20140513132404.5745456f@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mailout04.t-online.de (mailout04.t-online.de [194.25.134.18])
 by gabe.freedesktop.org (Postfix) with ESMTP id C6D1E6E21D
 for <intel-gfx@lists.freedesktop.org>; Tue, 13 May 2014 22:35:38 -0700 (PDT)
In-Reply-To: <20140513132404.5745456f@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
List-Id: intel-gfx@lists.freedesktop.org

On 13.05.2014 22:24, Jesse Barnes wrote:
> On Tue, 13 May 2014 16:50:12 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
>> On Tue, May 13, 2014 at 04:07:37PM +0100, Chris Wilson wrote:
>>> This matches the algorithm used by earlier kernels when selecting the
>>> mode for the fbcon. And only if there is no modes at all, do we fall
>>> back to using the BIOS configuration. Seamless transition is still
>>> preserved (from the BIOS configuration to ours) so long as the BIOS has
>>> also chosen what we hope is the native configuration.
>>>
>>> Reported-by: Knut Petersen <Knut_Petersen@t-online.de>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78655
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: stable@vger.kernel.org
I don't think that  Cc: stable@vger.kernel.org is necessary, kernels up to 3.14.x don't
expose the problem. And as this fixes a post-3.14 regression this is a clear candidate for
3.15

>>> ---
>>>   drivers/gpu/drm/i915/intel_fbdev.c | 8 ++++++++
>>>   1 file changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
>>> index 1d3f0a9cce31..05beec4badd5 100644
>>> --- a/drivers/gpu/drm/i915/intel_fbdev.c
>>> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
>>> @@ -397,6 +397,14 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
>>>   							  height);
>>>   		}
>>>   
>>> +		/* No preferred mode marked by the EDID? Are there any modes? */
>>> +		if (!modes[i] && !list_empty(&connector->modes)) {
>>> +			DRM_DEBUG_KMS("using first mode listed on connector %s\n",
>>> +				      drm_get_connector_name(connector));
>>> +			modes[i] = list_first_entry(struct drm_display_mode,
>>> +						    &connector->modes, head);
>> Please imagine that I wrote this correctly.
> Imagining you wrote it correctly:
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

After proper imagination Tested-by: Knut Petersen <Knut_Petersen@t-online.de>.