From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kumar, Shobhit" Subject: Re: [PATCH 23/66] drm/i915/dsi: Remove ->mode_set callback Date: Tue, 20 May 2014 17:29:46 +0530 Message-ID: <537B43B2.50208@intel.com> References: <1398376542-27825-1-git-send-email-daniel.vetter@ffwll.ch> <1398376542-27825-24-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 2AF626E79C for ; Tue, 20 May 2014 04:59:49 -0700 (PDT) In-Reply-To: <1398376542-27825-24-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On 4/25/2014 3:24 AM, Daniel Vetter wrote: > Looking at our current dsi driver I note that: > - We don't have any slave driver right now. > - There's zero support for the hardware state readout and cross check > code. > - All the modeset state seems to be tracked in the intel_dsi structure > instead of the pipe config. > > Given all that I can't properly audit the dsi ->mode_set callback. So > just do it as the first thing in the ->pre_pll_enable hook and hope > for the best. > Though this is merged, given the uncertainty around this in absence of panel driver. Verified-by: Shobhit Kumar Regards Shobhit