From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kumar, Shobhit" <shobhit.kumar@intel.com>
Subject: Re: [v2] drm/i915: Add support for Generic MIPI panel
	driver
Date: Tue, 27 May 2014 16:51:55 +0530
Message-ID: <53847553.2040703@intel.com>
References: <1397454507-10273-5-git-send-email-shobhit.kumar@intel.com>
 <1400861127-11475-1-git-send-email-shobhit.kumar@intel.com>
 <20140527110243.GA18389@strange.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
 by gabe.freedesktop.org (Postfix) with ESMTP id 70B5E6E3EC
 for <intel-gfx@lists.freedesktop.org>; Tue, 27 May 2014 04:22:01 -0700 (PDT)
In-Reply-To: <20140527110243.GA18389@strange.amr.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, Daniel Vetter <daniel.vetter@intel.com>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On 5/27/2014 4:32 PM, Damien Lespiau wrote:
> On Fri, May 23, 2014 at 09:35:27PM +0530, Shobhit Kumar wrote:
>> This driver makes use of the generic panel information from the VBT.
>> Panel information is classified into two - panel configuration and panel
>> power sequence which is unique to each panel. The generic driver uses the
>> panel configuration and sequence parsed from VBT block #52 and #53
>>
>> v2: Address review comments by Jani
>>      - Move all of the things in driver c file from header
>>      - Make all functions static
>>      - Make use of video/mipi_display.c instead of redefining
>>      - Null checks during sequence execution
>>
>> v3: Address review comments by Damien
>>      - Rename the panel driver file as intel_dsi_panel_vbt.c
>>      - Fix style changes as suggested
>>      - Correct comments for lp->hs and hs->lp count calculations
>>      - General updating comments to have more clarity
>>      - using max() instead of ternary operator
>>      - Fix names (ui_num, ui_den) while using UI in calculations
>>      - compute max of lp_to_hs switch and hs_to_lp switch while computing
>>        hs_lp_switch_count
>>
>> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
>
> Hopefully still works after all that :)

It does, at least on AsusT100 :) Thanks for the review

Regards
Shobhit

>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
>
> There's a small style issue I noticed with a last peek at the patch.
>> +static bool generic_mode_fixup(struct intel_dsi_device *dsi,
>> +		    const struct drm_display_mode *mode,
>> +		    struct drm_display_mode *adjusted_mode) {
>> +	return true;
>> +}
>