public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Thomas Richter <richter@rus.uni-stuttgart.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: [Patch] Disabling the pipe A quirk for the Fujitsu S6010
Date: Mon, 02 Jun 2014 17:38:13 +0200	[thread overview]
Message-ID: <538C9A65.1050704@rus.uni-stuttgart.de> (raw)
In-Reply-To: <20140602152702.GU19050@phenom.ffwll.local>

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

Hi Daniel, hi others,

please find a patch attached that disables the pipe A quirk for the 
Fujitsu S6010. I will probably add a line for the R31 later, I only
need to add the model number.

How is the watermark-alignment patch for the 830 doing, btw?

Greetings,
	Thomas


[-- Attachment #2: 0002-Disabling-the-pipe-A-quirk-for-the-Fujitsu-S6010.patch --]
[-- Type: text/x-patch, Size: 1561 bytes --]

>From 2006abcd850f8c0995153ffb491efd590103f17f Mon Sep 17 00:00:00 2001
From: thor <thor@math.tu-berlin.de>
Date: Mon, 2 Jun 2014 17:32:55 +0200
Subject: [PATCH 2/2] Disabling the pipe A quirk for the Fujitsu S6010.

Signed-off-by: thor <thor@math.tu-berlin.de>
---
 drivers/gpu/drm/i915/intel_display.c |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 54095d4..02b6525 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -11535,6 +11535,18 @@ static void quirk_pipea_force(struct drm_device *dev)
 }
 
 /*
+ * Some 830 based systems do not work with the pipe A quirk
+ * correctly since they do not use pipe A in first place
+ */
+static void quirk_disable_pipea_force(struct drm_device *dev)
+{
+	struct drm_i915_private *dev_priv = dev->dev_private;
+
+	dev_priv->quirks &= ~QUIRK_PIPEA_FORCE;
+	DRM_INFO("removing the pipe a force quirk for this hardware\n");
+}
+
+/*
  * Some machines (Lenovo U160) do not work with SSC on LVDS for some reason
  */
 static void quirk_ssc_force_disable(struct drm_device *dev)
@@ -11603,6 +11615,9 @@ static struct intel_quirk intel_quirks[] = {
 	/* 830 needs to leave pipe A & dpll A up */
 	{ 0x3577, PCI_ANY_ID, PCI_ANY_ID, quirk_pipea_force },
 
+	/* However, do not enable the quirk on S6010 */
+	{ 0x3577, 0x10cf, 0x113c, quirk_disable_pipea_force },
+
 	/* Lenovo U160 cannot use SSC on LVDS */
 	{ 0x0046, 0x17aa, 0x3920, quirk_ssc_force_disable },
 
-- 
1.7.10.4


[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2014-06-02 15:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16 14:02 830GM still woes Thomas Richter
2014-05-16 14:41 ` Chris Wilson
2014-05-16 15:09   ` Daniel Vetter
2014-05-16 16:04     ` Ville Syrjälä
2014-05-16 16:50       ` Daniel Vetter
     [not found]       ` <23914_1400259040_537641E0_23914_9298_1_20140516165034.GT8790@phenom.ffwll.local>
2014-05-17 10:58         ` Thomas Richter
2014-05-29 14:10         ` Thomas Richter
2014-05-29 21:19         ` Breaking suspend/resume by the Pipe A quirk Thomas Richter
2014-06-02  8:27           ` Daniel Vetter
2014-06-02 10:34             ` [PATCH] Align i830 watermark to cache lines Thomas Richter
2014-06-02 10:41             ` Breaking suspend/resume by the Pipe A quirk Thomas Richter
2014-06-02 15:27               ` Daniel Vetter
2014-06-02 15:38                 ` Thomas Richter [this message]
2014-06-02 15:56                   ` [Patch] Disabling the pipe A quirk for the Fujitsu S6010 Daniel Vetter
2014-06-02 16:52                     ` Thomas Richter
2014-06-02 17:39                       ` Daniel Vetter
2014-06-02 18:44                         ` Thomas Richter
     [not found]               ` <1027_1401722832_538C97D0_1027_15897_1_20140602152702.GU19050@phenom.ffwll.local>
2014-06-03 14:38                 ` Breaking suspend/resume by the Pipe A quirk Thomas Richter
2014-06-03 14:45                   ` Daniel Vetter
2014-06-03 15:04                     ` Thomas Richter
2014-06-03 15:14                       ` Chris Wilson
2014-06-03 15:19                         ` Thomas Richter
2014-06-03 15:26                           ` Chris Wilson
2014-06-03 15:50                             ` Thomas Richter
2014-06-03 16:03                               ` Chris Wilson
     [not found]                               ` <17205_1401811442_538DF1F2_17205_16362_1_20140603160352.GA6129@nuc-i3427.alporthouse.com>
2014-06-04 22:43                                 ` Bug: Pipe A underrun on resolution switching on 830MG Thomas Richter
2014-06-08 21:20                                 ` Broken suspend/resume on i830 (with debug information) Thomas Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538C9A65.1050704@rus.uni-stuttgart.de \
    --to=richter@rus.uni-stuttgart.de \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox