Re: [PATCH 08/11] drm/i915: BDW PSR: Remove limitations that aren't valid for BDW.

[Vijay Purushothaman <vijay.a.purushothaman@intel.com>]

On 5/16/2014 5:43 AM, Rodrigo Vivi wrote:
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> ---
>   drivers/gpu/drm/i915/intel_dp.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 28144d3..9421b0b 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1768,6 +1768,10 @@ static bool intel_edp_psr_match_conditions(struct intel_dp *intel_dp)
>   		return false;
>   	}
>
> +	/* Below limitations aren't valid for Broadwell */
> +	if (IS_BROADWELL(dev))
> +		goto out;

I couldn't figure out any sprite related restrictions for HSW as well. 
Is this because FBC logic doesn't track sprites in HSW?

Thanks,
Vijay


> +
>   	if (I915_READ(SPRCTL(intel_crtc->pipe)) & SPRITE_ENABLE) {
>   		DRM_DEBUG_KMS("PSR condition failed: Sprite is Enabled\n");
>   		return false;
> @@ -1784,6 +1788,7 @@ static bool intel_edp_psr_match_conditions(struct intel_dp *intel_dp)
>   		return false;
>   	}
>
> + out:
>   	dev_priv->psr.source_ok = true;
>   	return true;
>   }
>