Re: [PATCH 11/11] drm/i915: PSR HSW: update after enabling sprite.

From: Vijay Purushothaman <vijay.a.purushothaman@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 11/11] drm/i915: PSR HSW: update after enabling sprite.
Date: Tue, 03 Jun 2014 16:55:09 +0530	[thread overview]
Message-ID: <538DB095.9050406@intel.com> (raw)
In-Reply-To: <1400199190-2424-12-git-send-email-rodrigo.vivi@gmail.com>

On 5/16/2014 5:43 AM, Rodrigo Vivi wrote:
> On the current structure HSW doesn't support PSR with sprites enabled
> but sprites can be enabled after PSR was enabled what would cause
> user to miss screen updates.

Could you please explain this a bit more? Did you get a confirmation 
from h/w team that this is not possible? AFAIK, HSW should be able to 
support PSR with sprites enabled.

Thanks,
Vijay

>
> v2: move it to update_plane.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> ---
>   drivers/gpu/drm/i915/intel_sprite.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 213cd58..4b85400 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -1051,6 +1051,8 @@ intel_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
>   		mutex_unlock(&dev->struct_mutex);
>   	}
>
> +	intel_edp_psr_update(dev);
> +
>   	return 0;
>   }
>
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx