From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Richter <richter@rus.uni-stuttgart.de>
Subject: Re: [PATCH 01/15] drm/i915: Use named initializers for
 gmch wm params
Date: Thu, 05 Jun 2014 23:02:01 +0200
Message-ID: <5390DAC9.60600@rus.uni-stuttgart.de>
References: <1401984964-25441-1-git-send-email-ville.syrjala@linux.intel.com>
 <1401984964-25441-2-git-send-email-ville.syrjala@linux.intel.com>
 <20140605204312.GA15324@nuc-i3427.alporthouse.com>
Reply-To: richter@rus.uni-stuttgart.de
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from medousa.rus.uni-stuttgart.de (medousa.rus.uni-stuttgart.de
 [129.69.192.4])
 by gabe.freedesktop.org (Postfix) with ESMTP id C63536E09A
 for <intel-gfx@lists.freedesktop.org>; Thu,  5 Jun 2014 14:02:13 -0700 (PDT)
In-Reply-To: <20140605204312.GA15324@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Am 05.06.2014 22:43, schrieb Chris Wilson:
> On Thu, Jun 05, 2014 at 07:15:50PM +0300, ville.syrjala@linux.intel.com w=
rote:
>> From: Ville Syrj=E4l=E4<ville.syrjala@linux.intel.com>
>>
>> Using names initializers when filling out the watermark structs
>> saves you from having go look up the struct definition every
>> single time.
>>
>> Signed-off-by: Ville Syrj=E4l=E4<ville.syrjala@linux.intel.com>
>
> Thank you,
> Reviewed-by: Chris Wilson<chris@chris-wilson.co.uk>

Thanks for the patch and for all the work, unfortunately it does not =

quite work as presented. I applied the patch correctly to =

drm-intel-nightly, and it compiles fine.

However, the following issues exist:

*) If you boot with the kernel parameter vga=3D792 (i.e. the same console =

resolutions as initiated by KMS) the system just hangs with a black =

screen. Booting aborts, nothing happens.

*) Watermark settings are *still* not correct. *SIGH*, *sigh*

intel_reg_read 0x20d8
0x20D8 : 0x11F0104

This is a watermark level of 4. As I said multiple times, the watermark =

register needs to be *AT LEAST* eight (in numbers, 8) to have a stable =

display. It is stable between 8 and 32.

To reproduce, use a panning display with xrandr:

xrandr --output DVI1 --mode 1024x768 --panning 2048x1536

then scroll, and see the display flicker.

Folks, I really appreciate all your effort, but I would be really happy =

if my comments on the wrong watermarks wouldn't be continuously ignored. =

I submitted patches, twice, thrice... all went into the trash.

Greetings,
	Thomas