From: "Kumar, Shobhit" <shobhit.kumar@intel.com>
To: "Jesse Barnes" <jesse.barnes@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Update bits to check in device class from VBT to detect eDP
Date: Fri, 06 Jun 2014 09:33:46 +0530 [thread overview]
Message-ID: <53913DA2.8020501@intel.com> (raw)
In-Reply-To: <20140605090417.75cd648b@jbarnes-desktop>
On 6/5/2014 9:34 PM, Jesse Barnes wrote:
> On Thu, 5 Jun 2014 16:09:29 +0300
> Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>
>> On Thu, Jun 05, 2014 at 06:25:13PM +0530, Shobhit Kumar wrote:
>>> The DEVICE_TYPE_eDP has been changed to 0x1806 in case of BYT which
>>> can causes wrong detection failures for eDP. Reduce the number of bits
>>> of interest in DEVICE_TYPE_eDP_BITS to just check most relevant and
>>> conclusive ones and ensure they are set in device_class from VBT. This
>>> will ensure that eDP detection works across platforms
>>
>> The current bits will match correctly for 0x1806. I don't have a problem
>> with the patch per-say but would be nice to know what the troublesome
>> device type really was, if indeed there was one. I'm just slightly
>> worried that we might start to get false positives on some platforms if
>> we make it too relaxed.
>
> Still waiting for results, but
> https://bugs.freedesktop.org/show_bug.cgi?id=78795 was what motivated this.
>
Yeah and update from Jesse that forcefully returning true from the
function make things work, I assumed this is the reason, without really
checking that even the old values will result DEVIVE_TYPE_eDP &
DEVICE_TYPE_eDP_BITS = 0x1806 :)
Nevertheless I still feel that a simplified bit mask is good to have. We
need to check further on this issue Jesse. Let me know once you have
results. It would be still better to spit out the device_type being read
from VBT as a log to confirm that indeed it is coming as 0x1806 or can
just ask to get the opregion dump from debugfs and we can check ourselves.
Regards
Shobhit
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-06-06 4:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 12:55 [PATCH] drm/i915: Update bits to check in device class from VBT to detect eDP Shobhit Kumar
2014-06-05 13:09 ` Ville Syrjälä
2014-06-05 16:04 ` Jesse Barnes
2014-06-06 4:03 ` Kumar, Shobhit [this message]
2014-06-06 5:36 ` Kumar, Shobhit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53913DA2.8020501@intel.com \
--to=shobhit.kumar@intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jesse.barnes@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox