From: Hans de Goede <hdegoede@redhat.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Jani Nikula <jani.nikula@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] backlight: Don't read back backlight setting from kernel on DPMS off
Date: Fri, 13 Jun 2014 10:49:12 +0200 [thread overview]
Message-ID: <539ABB08.4090602@redhat.com> (raw)
In-Reply-To: <20140607111239.GA9858@nuc-i3427.alporthouse.com>
Hi,
On 06/07/2014 01:12 PM, Chris Wilson wrote:
> On Sat, Jun 07, 2014 at 12:18:35PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 06/06/2014 04:51 PM, Chris Wilson wrote:
>>> commit c6cd10f536e099277cdc46643725a5a50ea8b525
>>> Author: Chris Wilson <chris@chris-wilson.co.uk>
>>> Date: Thu Jun 5 22:43:37 2014 +0100
>>
>> Thanks, I fail to see how this addresses the original problem though,
>> current master still reads back the backlight from the kernel at DPMS
>> off, so the problem my original patch in this thread tries to fix
>> still exists AFAIK, we will still read back 0 on DPMS off in the
>> scenario my patch tries to address.
>
> It changes the sequence in which output->funcs->dpms is called to
> prevent the bug.
Thanks, I don't see that being changed in the above commit though,
and I cannot find the commit in which it does change, can you point
me to the commit where this is changed ?
Regards,
Hans
next prev parent reply other threads:[~2014-06-13 8:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 13:48 [PATCH] backlight: Don't read back backlight setting from kernel on DPMS off Hans de Goede
2014-06-05 14:01 ` Jani Nikula
2014-06-05 14:29 ` Chris Wilson
2014-06-05 19:08 ` Hans de Goede
2014-06-05 20:24 ` Chris Wilson
2014-06-06 14:37 ` Hans de Goede
2014-06-06 14:51 ` Chris Wilson
2014-06-07 10:18 ` Hans de Goede
2014-06-07 11:12 ` Chris Wilson
2014-06-13 8:49 ` Hans de Goede [this message]
2014-06-13 9:00 ` Chris Wilson
2014-06-06 14:39 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539ABB08.4090602@redhat.com \
--to=hdegoede@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox