From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] backlight: Don't read back backlight
 setting from kernel on DPMS off
Date: Fri, 13 Jun 2014 10:49:12 +0200
Message-ID: <539ABB08.4090602@redhat.com>
References: <1401976118-8780-1-git-send-email-hdegoede@redhat.com>
 <8761kfe9qk.fsf@intel.com> <20140605142912.GB22214@nuc-i3427.alporthouse.com>
 <5390C031.4090500@redhat.com>
 <20140605202427.GC22214@nuc-i3427.alporthouse.com>
 <5391D230.30700@redhat.com>
 <20140606145127.GG22214@nuc-i3427.alporthouse.com>
 <5392E6FB.4020509@redhat.com>
 <20140607111239.GA9858@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by gabe.freedesktop.org (Postfix) with ESMTP id 447946E9D8
 for <intel-gfx@lists.freedesktop.org>; Fri, 13 Jun 2014 01:49:19 -0700 (PDT)
In-Reply-To: <20140607111239.GA9858@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Jani Nikula <jani.nikula@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Hi,

On 06/07/2014 01:12 PM, Chris Wilson wrote:
> On Sat, Jun 07, 2014 at 12:18:35PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 06/06/2014 04:51 PM, Chris Wilson wrote:
>>> commit c6cd10f536e099277cdc46643725a5a50ea8b525
>>> Author: Chris Wilson <chris@chris-wilson.co.uk>
>>> Date:   Thu Jun 5 22:43:37 2014 +0100
>>
>> Thanks, I fail to see how this addresses the original problem though,
>> current master still reads back the backlight from the kernel at DPMS
>> off, so the problem my original patch in this thread tries to fix
>> still exists AFAIK, we will still read back 0 on DPMS off in the
>> scenario my patch tries to address.
> 
> It changes the sequence in which output->funcs->dpms is called to
> prevent the bug.

Thanks, I don't see that being changed in the above commit though,
and I cannot find the commit in which it does change, can you point
me to the commit where this is changed ?

Regards,

Hans