From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sun, Daisy" Subject: Re: [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096 Date: Mon, 16 Jun 2014 13:41:36 -0700 Message-ID: <539F5680.2000001@intel.com> References: <1402937532-24673-1-git-send-email-damien.lespiau@intel.com> <20140616171145.GO32694@strange.amr.corp.intel.com> <20140616181549.GJ5821@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 769B46E5ED for ; Mon, 16 Jun 2014 13:41:37 -0700 (PDT) In-Reply-To: <20140616181549.GJ5821@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Yes, the change starts from HSW. I'll update the patch. what's the "rant" I need to insert? I was not in the list a year ago:), having some trouble find the email as reference. Any archives I can look into? On 6/16/2014 11:15 AM, Daniel Vetter wrote: > On Mon, Jun 16, 2014 at 06:11:45PM +0100, Damien Lespiau wrote: >> On Mon, Jun 16, 2014 at 05:52:12PM +0100, Damien Lespiau wrote: >>> From: Daisy Sun >>> >>> Staring from BDW, the resolution limit of FBC has increased to >>> 4096x4096> >>> >>> Issue: APDEV-2935 >>> Otc-Tracker: VIZ-3826 >>> Change-Id: I842f64e3cf2c0d18d29ef1bcfef3b9bb1f1764ac >>> Signed-off-by: Daisy Sun >> Reviewed-by: Damien Lespiau > Iirc 4kx4k is allowed on hsw already, albeit with the lower 2k lines being > uncompressed. Please double-check bspec and update the patch. > > Also: Please insert rant here that I've written a mail a year ago about > the piles of little issues in our fbc feature checking. > -Daniel > >> -- >> Damien >> >>> --- >>> drivers/gpu/drm/i915/intel_pm.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c >>> index 0b088fe..8cc60fc 100644 >>> --- a/drivers/gpu/drm/i915/intel_pm.c >>> +++ b/drivers/gpu/drm/i915/intel_pm.c >>> @@ -529,7 +529,10 @@ void intel_update_fbc(struct drm_device *dev) >>> goto out_disable; >>> } >>> >>> - if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) { >>> + if (INTEL_INFO(dev)->gen >= 8) { >>> + max_width = 4096; >>> + max_height = 4096; >>> + } else if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) { >>> max_width = 4096; >>> max_height = 2048; >>> } else { >>> -- >>> 1.8.3.1 >>> >>> _______________________________________________ >>> Intel-gfx mailing list >>> Intel-gfx@lists.freedesktop.org >>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx