* [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096
@ 2014-06-16 16:52 Damien Lespiau
2014-06-16 17:11 ` Damien Lespiau
0 siblings, 1 reply; 6+ messages in thread
From: Damien Lespiau @ 2014-06-16 16:52 UTC (permalink / raw)
To: intel-gfx
From: Daisy Sun <daisy.sun@intel.com>
Staring from BDW, the resolution limit of FBC has increased to
4096x4096>
Issue: APDEV-2935
Otc-Tracker: VIZ-3826
Change-Id: I842f64e3cf2c0d18d29ef1bcfef3b9bb1f1764ac
Signed-off-by: Daisy Sun <daisy.sun@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 0b088fe..8cc60fc 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -529,7 +529,10 @@ void intel_update_fbc(struct drm_device *dev)
goto out_disable;
}
- if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) {
+ if (INTEL_INFO(dev)->gen >= 8) {
+ max_width = 4096;
+ max_height = 4096;
+ } else if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) {
max_width = 4096;
max_height = 2048;
} else {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096
2014-06-16 16:52 [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096 Damien Lespiau
@ 2014-06-16 17:11 ` Damien Lespiau
2014-06-16 18:15 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Damien Lespiau @ 2014-06-16 17:11 UTC (permalink / raw)
To: intel-gfx
On Mon, Jun 16, 2014 at 05:52:12PM +0100, Damien Lespiau wrote:
> From: Daisy Sun <daisy.sun@intel.com>
>
> Staring from BDW, the resolution limit of FBC has increased to
> 4096x4096>
>
> Issue: APDEV-2935
> Otc-Tracker: VIZ-3826
> Change-Id: I842f64e3cf2c0d18d29ef1bcfef3b9bb1f1764ac
> Signed-off-by: Daisy Sun <daisy.sun@intel.com>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
> ---
> drivers/gpu/drm/i915/intel_pm.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 0b088fe..8cc60fc 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -529,7 +529,10 @@ void intel_update_fbc(struct drm_device *dev)
> goto out_disable;
> }
>
> - if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) {
> + if (INTEL_INFO(dev)->gen >= 8) {
> + max_width = 4096;
> + max_height = 4096;
> + } else if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) {
> max_width = 4096;
> max_height = 2048;
> } else {
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096
2014-06-16 17:11 ` Damien Lespiau
@ 2014-06-16 18:15 ` Daniel Vetter
2014-06-16 20:41 ` Sun, Daisy
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2014-06-16 18:15 UTC (permalink / raw)
To: Damien Lespiau; +Cc: intel-gfx
On Mon, Jun 16, 2014 at 06:11:45PM +0100, Damien Lespiau wrote:
> On Mon, Jun 16, 2014 at 05:52:12PM +0100, Damien Lespiau wrote:
> > From: Daisy Sun <daisy.sun@intel.com>
> >
> > Staring from BDW, the resolution limit of FBC has increased to
> > 4096x4096>
> >
> > Issue: APDEV-2935
> > Otc-Tracker: VIZ-3826
> > Change-Id: I842f64e3cf2c0d18d29ef1bcfef3b9bb1f1764ac
> > Signed-off-by: Daisy Sun <daisy.sun@intel.com>
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Iirc 4kx4k is allowed on hsw already, albeit with the lower 2k lines being
uncompressed. Please double-check bspec and update the patch.
Also: Please insert rant here that I've written a mail a year ago about
the piles of little issues in our fbc feature checking.
-Daniel
>
> --
> Damien
>
> > ---
> > drivers/gpu/drm/i915/intel_pm.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 0b088fe..8cc60fc 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -529,7 +529,10 @@ void intel_update_fbc(struct drm_device *dev)
> > goto out_disable;
> > }
> >
> > - if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) {
> > + if (INTEL_INFO(dev)->gen >= 8) {
> > + max_width = 4096;
> > + max_height = 4096;
> > + } else if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) {
> > max_width = 4096;
> > max_height = 2048;
> > } else {
> > --
> > 1.8.3.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096
2014-06-16 18:15 ` Daniel Vetter
@ 2014-06-16 20:41 ` Sun, Daisy
2014-06-16 21:49 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Sun, Daisy @ 2014-06-16 20:41 UTC (permalink / raw)
To: Daniel Vetter, Damien Lespiau; +Cc: intel-gfx
Yes, the change starts from HSW. I'll update the patch.
what's the "rant" I need to insert? I was not in the list a year ago:),
having some trouble find the email as reference.
Any archives I can look into?
On 6/16/2014 11:15 AM, Daniel Vetter wrote:
> On Mon, Jun 16, 2014 at 06:11:45PM +0100, Damien Lespiau wrote:
>> On Mon, Jun 16, 2014 at 05:52:12PM +0100, Damien Lespiau wrote:
>>> From: Daisy Sun <daisy.sun@intel.com>
>>>
>>> Staring from BDW, the resolution limit of FBC has increased to
>>> 4096x4096>
>>>
>>> Issue: APDEV-2935
>>> Otc-Tracker: VIZ-3826
>>> Change-Id: I842f64e3cf2c0d18d29ef1bcfef3b9bb1f1764ac
>>> Signed-off-by: Daisy Sun <daisy.sun@intel.com>
>> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> Iirc 4kx4k is allowed on hsw already, albeit with the lower 2k lines being
> uncompressed. Please double-check bspec and update the patch.
>
> Also: Please insert rant here that I've written a mail a year ago about
> the piles of little issues in our fbc feature checking.
> -Daniel
>
>> --
>> Damien
>>
>>> ---
>>> drivers/gpu/drm/i915/intel_pm.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>>> index 0b088fe..8cc60fc 100644
>>> --- a/drivers/gpu/drm/i915/intel_pm.c
>>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>>> @@ -529,7 +529,10 @@ void intel_update_fbc(struct drm_device *dev)
>>> goto out_disable;
>>> }
>>>
>>> - if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) {
>>> + if (INTEL_INFO(dev)->gen >= 8) {
>>> + max_width = 4096;
>>> + max_height = 4096;
>>> + } else if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) {
>>> max_width = 4096;
>>> max_height = 2048;
>>> } else {
>>> --
>>> 1.8.3.1
>>>
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096
2014-06-16 20:41 ` Sun, Daisy
@ 2014-06-16 21:49 ` Daniel Vetter
2014-06-16 22:55 ` Sun, Daisy
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2014-06-16 21:49 UTC (permalink / raw)
To: Sun, Daisy; +Cc: intel-gfx
On Mon, Jun 16, 2014 at 10:41 PM, Sun, Daisy <daisy.sun@intel.com> wrote:
> Yes, the change starts from HSW. I'll update the patch.
> what's the "rant" I need to insert? I was not in the list a year ago:),
> having some trouble find the email as reference.
> Any archives I can look into?
No rant to insert for you ;-) That was a placeholder in my mail,
instead of boring people with all the details. Iirc that was to the
internal mailing list, and could be older than a year even.
Essentially there's a bunch of constraints about pixel depth and pfit
usage on recent platforms that we don't quite check correctly. Your
patch update to check for gen >= 8 || IS_HASWELL is perfectly fine
as-is.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096
2014-06-16 21:49 ` Daniel Vetter
@ 2014-06-16 22:55 ` Sun, Daisy
0 siblings, 0 replies; 6+ messages in thread
From: Sun, Daisy @ 2014-06-16 22:55 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
IC. I started working from BDW FBC, did not check all the gens
thoroughly:-)
Sent out a version 2 just now.
- Daisy
On 6/16/2014 2:49 PM, Daniel Vetter wrote:
> On Mon, Jun 16, 2014 at 10:41 PM, Sun, Daisy <daisy.sun@intel.com> wrote:
>> Yes, the change starts from HSW. I'll update the patch.
>> what's the "rant" I need to insert? I was not in the list a year ago:),
>> having some trouble find the email as reference.
>> Any archives I can look into?
> No rant to insert for you ;-) That was a placeholder in my mail,
> instead of boring people with all the details. Iirc that was to the
> internal mailing list, and could be older than a year even.
>
> Essentially there's a bunch of constraints about pixel depth and pfit
> usage on recent platforms that we don't quite check correctly. Your
> patch update to check for gen >= 8 || IS_HASWELL is perfectly fine
> as-is.
> -Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-16 22:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-16 16:52 [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096 Damien Lespiau
2014-06-16 17:11 ` Damien Lespiau
2014-06-16 18:15 ` Daniel Vetter
2014-06-16 20:41 ` Sun, Daisy
2014-06-16 21:49 ` Daniel Vetter
2014-06-16 22:55 ` Sun, Daisy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox