From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sun, Daisy" Subject: Re: [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096 Date: Mon, 16 Jun 2014 15:55:16 -0700 Message-ID: <539F75D4.7030105@intel.com> References: <1402937532-24673-1-git-send-email-damien.lespiau@intel.com> <20140616171145.GO32694@strange.amr.corp.intel.com> <20140616181549.GJ5821@phenom.ffwll.local> <539F5680.2000001@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 1575B6E3E7 for ; Mon, 16 Jun 2014 15:55:17 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org IC. I started working from BDW FBC, did not check all the gens thoroughly:-) Sent out a version 2 just now. - Daisy On 6/16/2014 2:49 PM, Daniel Vetter wrote: > On Mon, Jun 16, 2014 at 10:41 PM, Sun, Daisy wrote: >> Yes, the change starts from HSW. I'll update the patch. >> what's the "rant" I need to insert? I was not in the list a year ago:), >> having some trouble find the email as reference. >> Any archives I can look into? > No rant to insert for you ;-) That was a placeholder in my mail, > instead of boring people with all the details. Iirc that was to the > internal mailing list, and could be older than a year even. > > Essentially there's a bunch of constraints about pixel depth and pfit > usage on recent platforms that we don't quite check correctly. Your > patch update to check for gen >= 8 || IS_HASWELL is perfectly fine > as-is. > -Daniel