Re: [Intel-gfx] [PATCH 03/11] drm/i915: add some registers need for displayport MST support.

Todd Previte
2014-05-23T04:22:47Z

[-- Attachment #1.1: Type: text/plain, Size: 2803 bytes --]

> Dave Airlie <mailto:airlied@gmail.com>
> Tuesday, May 20, 2014 7:54 PM
> From: Dave Airlie <airlied@redhat.com>
>
> These are just from the Haswell spec.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h
> index 8f84555..557b37a 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -5386,6 +5386,7 @@ enum punit_power_well {
> #define TRANS_DDI_EDP_INPUT_A_ONOFF (4<<12)
> #define TRANS_DDI_EDP_INPUT_B_ONOFF (5<<12)
> #define TRANS_DDI_EDP_INPUT_C_ONOFF (6<<12)
> +#define TRANS_DDI_DP_VC_PAYLOAD_ALLOC (1<<8)
> #define TRANS_DDI_BFI_ENABLE (1<<4)
>
> /* DisplayPort Transport Control */
> @@ -5395,6 +5396,7 @@ enum punit_power_well {
> #define DP_TP_CTL_ENABLE (1<<31)
> #define DP_TP_CTL_MODE_SST (0<<27)
> #define DP_TP_CTL_MODE_MST (1<<27)
> +#define DP_TP_CTL_FORCE_ACT (1<<25)
> #define DP_TP_CTL_ENHANCED_FRAME_ENABLE (1<<18)
> #define DP_TP_CTL_FDI_AUTOTRAIN (1<<15)
> #define DP_TP_CTL_LINK_TRAIN_MASK (7<<8)
> @@ -5409,8 +5411,13 @@ enum punit_power_well {
> #define DP_TP_STATUS_A 0x64044
> #define DP_TP_STATUS_B 0x64144
> #define DP_TP_STATUS(port) _PORT(port, DP_TP_STATUS_A, DP_TP_STATUS_B)
> -#define DP_TP_STATUS_IDLE_DONE (1<<25)
> -#define DP_TP_STATUS_AUTOTRAIN_DONE (1<<12)
> +#define DP_TP_STATUS_IDLE_DONE (1<<25)
> +#define DP_TP_STATUS_ACT_SENT (1<<24)
> +#define DP_TP_STATUS_MODE_STATUS_MST (1<<23)
> +#define DP_TP_STATUS_AUTOTRAIN_DONE (1<<12)
> +#define DP_TP_STATUS_PAYLOAD_MAPPING_VC2 (3 << 8)
> +#define DP_TP_STATUS_PAYLOAD_MAPPING_VC1 (3 << 4)
> +#define DP_TP_STATUS_PAYLOAD_MAPPING_VC0 (3 << 0)
>
> /* DDI Buffer Control */
> #define DDI_BUF_CTL_A 0x64000
Definitions look correct. If I noticed any discrepancies during testing,
I'll flag it.

Reviewed-by: Todd Previte <tprevite@gmail.com>
> Dave Airlie <mailto:airlied@gmail.com>
> Tuesday, May 20, 2014 7:54 PM
> Hey,
>
> So this set is pretty close to what I think we should be merging
> initially,
>
> Since the last set, it makes fbcon and suspend/resume work a lot better,
>
> I've also fixed a couple of bugs in -intel that make things work a lot
> better.
>
> I've bashed on this a bit using kms-flip from intel-gpu-tools, hacked
> to add 3 monitor support.
>
> It still generates a fair few i915 state checker backtraces, and some
> of them are fairly hard to work out, it might be we should just tone
> down the state checker for encoders/connectors with no actual hw backing
> them.
>
> Dave.
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[-- Attachment #1.2.1: Type: text/html, Size: 6264 bytes --]

[-- Attachment #1.2.2: postbox-contact.jpg --]
[-- Type: image/jpeg, Size: 1291 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org