From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jindal, Sonika" <sonika.jindal@intel.com>
Subject: Re: [PATCH 11/11] tests/kms_rotation_crc: IGT for 180
 degree HW rotation
Date: Wed, 18 Jun 2014 17:30:48 +0530
Message-ID: <53A17F70.4030607@intel.com>
References: <1403081847-4364-1-git-send-email-sonika.jindal@intel.com>
 <1403081847-4364-12-git-send-email-sonika.jindal@intel.com>
 <20140618113200.GD18833@strange.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
 by gabe.freedesktop.org (Postfix) with ESMTP id 419AF6E50D
 for <intel-gfx@lists.freedesktop.org>; Wed, 18 Jun 2014 05:00:52 -0700 (PDT)
In-Reply-To: <20140618113200.GD18833@strange.amr.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org



On 6/18/2014 5:02 PM, Damien Lespiau wrote:
> On Wed, Jun 18, 2014 at 02:27:27PM +0530, sonika.jindal@intel.com wrote:
>> From: Sonika Jindal <sonika.jindal@intel.com>
>>
>> Testcase for 180 degree HW rotation
>>
>> Cc: sagar.a.kamble@intel.com
>>
>> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
>
> The test looks good to me (I haven't checked in details, the bar for igt
> is quite a bit lower). It shows two gaps in the igt kms API:
>
>    - Retrieving the primary plane (there's a series from Matt fixing this
>      and exposing the primary plane through igt_output_get_plane())
True, thats why I am checking for type property in this test. Can be 
removed once Matt's patches are merged
>    - Adding a set_property() convenience function
>      (ala igt_plane_set_property("rotation", BIT(DRM_ROTATE_180)))
>      (no-one is working on that just yet, can de done later)
Sure, will be good to have.
>
> A small question before pushing this, have you checked that the test
> correctly skips when running with a kernel without rotation support?
NO, I haven't tested that. Will try in sometime and let you know if I 
see any issue there.
>
> Thanks,
>