From mboxrd@z Thu Jan 1 00:00:00 1970 From: Deepak S Subject: Re: [PATCH v2] drm/i915: Bring GPU Freq to min while suspending. Date: Thu, 19 Jun 2014 08:53:24 +0530 Message-ID: <53A257AC.5040108@linux.intel.com> References: <1403049653-31480-1-git-send-email-deepak.s@linux.intel.com> <20140617221723.GX5821@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 41D196E1A3 for ; Tue, 17 Jun 2014 20:28:35 -0700 (PDT) In-Reply-To: <20140617221723.GX5821@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wednesday 18 June 2014 03:47 AM, Daniel Vetter wrote: > On Wed, Jun 18, 2014 at 05:30:53AM +0530, deepak.s@linux.intel.com wrote: >> From: Deepak S >> >> We might be leaving the GPU Frequency (and thus vnn) high during the suspend. >> Flush the delayed work queue should take care of this. >> >> v2: Fixed typo in commit message (Deepak) >> >> Signed-off-by: Deepak S >> --- >> drivers/gpu/drm/i915/i915_gem.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c >> index 7f643db..8d5ae82 100644 >> --- a/drivers/gpu/drm/i915/i915_gem.c >> +++ b/drivers/gpu/drm/i915/i915_gem.c >> @@ -4541,7 +4541,7 @@ i915_gem_suspend(struct drm_device *dev) >> >> del_timer_sync(&dev_priv->gpu_error.hangcheck_timer); >> cancel_delayed_work_sync(&dev_priv->mm.retire_work); >> - cancel_delayed_work_sync(&dev_priv->mm.idle_work); >> + flush_delayed_work(&dev_priv->mm.idle_work); > Shouldn't we do that in suspend_gt_powersave instead? Also if we cancel > the retire work the idle work won't necessarily get armed and we might > miss the window. Just forcing the gt to the lowest freq in > suspend_gt_powersave should be more reliable. > -Daniel Since we a calling suspend_gt_powersave after i915_gem_suspend, i added the flush in suspend. Yes i agree forcing the gt freq us more reliable