From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sun, Daisy" Subject: Re: [PATCH v2] drm/i915/bdw: BDW Software Turbo Date: Thu, 10 Jul 2014 19:39:32 -0700 Message-ID: <53BF4E64.2040802@intel.com> References: <1404954048-15265-1-git-send-email-daisy.sun@intel.com> <20140710083238.GK8986@nuc-i3427.alporthouse.com> <53BEDEB3.2000003@intel.com> <20140710190754.GN8986@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 64AAE6E7F2 for ; Thu, 10 Jul 2014 19:39:39 -0700 (PDT) In-Reply-To: <20140710190754.GN8986@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This Software turbo will mainly take place of the hardware driven interrupt part without touching the boost/idle strategy. So gen6_rps_boost and gen6_rps_idle will still function for BDW. I can revise the commit message to clarify. On 7/10/2014 12:07 PM, Chris Wilson wrote: > On Thu, Jul 10, 2014 at 11:42:59AM -0700, Sun, Daisy wrote: >> GT is not going to run at a single frequency all the time actually. >> It starts from a single frequency, and then will dynamically adjust >> according to the GT utilization, either go up or down. >> From this perspective, SW turbo function the same as the HW turbo. > Urm, read your code again. > >> For the algorithm, we did go over the design forum before implementation. >> What kind of improvement is expected? Please let me know if any >> important case is not taken into account. Thanks. > You have no faststart or boost strategy, so typical desktop usage will > feel very laggy. For a large number of use cases you never change > freequency. > -Chris >