From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 3/3] igt/gem_userptr_blits: Verify that
 userptr bo work on unshared memory
Date: Fri, 11 Jul 2014 11:45:25 +0100
Message-ID: <53BFC045.1090109@linux.intel.com>
References: <1405071640-29692-1-git-send-email-chris@chris-wilson.co.uk>
 <1405071640-29692-3-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 909866E1FE
 for <intel-gfx@lists.freedesktop.org>; Fri, 11 Jul 2014 03:45:30 -0700 (PDT)
In-Reply-To: <1405071640-29692-3-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org


On 07/11/2014 10:40 AM, Chris Wilson wrote:
> If the parent passes a userptr to some private memory, we expect to
> still be able to use the userptr in the child.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/gem_userptr_blits.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 52 insertions(+)
>
> diff --git a/tests/gem_userptr_blits.c b/tests/gem_userptr_blits.c
> index 9cf681b..454db58 100644
> --- a/tests/gem_userptr_blits.c
> +++ b/tests/gem_userptr_blits.c
> @@ -542,6 +542,55 @@ static int test_invalid_mapping(int fd)
>   	return 0;
>   }
>
> +static void test_forked_access(int fd)
> +{
> +	uint32_t handle1, handle2;
> +	void *ptr1, *ptr2;
> +	int ret;
> +
> +	ret = posix_memalign(&ptr1, PAGE_SIZE, PAGE_SIZE);
> +	igt_assert(ret == 0);
> +
> +	ret = madvise(ptr1, PAGE_SIZE, MADV_DONTFORK);
> +	igt_assert(ret == 0);
> +
> +	ret = gem_userptr(fd, ptr1, PAGE_SIZE, 0, &handle1);
> +	igt_assert(ret == 0);
> +
> +	ret = posix_memalign(&ptr2, PAGE_SIZE, PAGE_SIZE);
> +	igt_assert(ret == 0);
> +
> +	ret = madvise(ptr2, PAGE_SIZE, MADV_DONTFORK);
> +	igt_assert(ret == 0);
> +
> +	ret = gem_userptr(fd, ptr2, PAGE_SIZE, 0, &handle2);
> +	igt_assert(ret == 0);
> +
> +	memset(ptr1, 0x1, PAGE_SIZE);
> +	memset(ptr2, 0x2, PAGE_SIZE);
> +
> +	igt_fork(child, 1) {
> +		copy(fd, handle1, handle2, 0);
> +	}
> +	igt_waitchildren();
> +
> +	gem_userptr_sync(fd, handle1);
> +	gem_userptr_sync(fd, handle2);
> +
> +	gem_close(fd, handle1);
> +	gem_close(fd, handle2);
> +
> +	igt_assert(memcmp(ptr1, ptr2, PAGE_SIZE) == 0);
> +
> +	ret = madvise(ptr1, PAGE_SIZE, MADV_DOFORK);
> +	igt_assert(ret == 0);
> +	free(ptr1);
> +
> +	ret = madvise(ptr2, PAGE_SIZE, MADV_DOFORK);
> +	igt_assert(ret == 0);
> +	free(ptr2);
> +}
> +
>   static int test_forbidden_ops(int fd)
>   {
>   	void *ptr;
> @@ -1108,6 +1157,9 @@ int main(int argc, char **argv)
>   	igt_subtest("invalid-mapping")
>   		test_invalid_mapping(fd);
>
> +	igt_subtest("forked-access")
> +		test_forked_access(fd);
> +
>   	igt_subtest("forbidden-operations")
>   		test_forbidden_ops(fd);
>
>

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>