Re: [PATCH 0/6] Add 180 degree primary and sprite rotation

["Jindal, Sonika" <sonika.jindal@intel.com>]

On 7/15/2014 4:22 PM, Damien Lespiau wrote:
> On Tue, Jul 15, 2014 at 02:10:23PM +0530, sonika.jindal@intel.com wrote:
>> From: Sonika Jindal <sonika.jindal@intel.com>
>>
>> This patchset provides support for 0/180 degree hardare rotaion for primary and
>> sprite planes. The rotation property is now made global and is part of
>> drm_mode_config. It is attached to different planes.
>>
>> Sonika Jindal (3):
>>    drm: Add rotation_property to mode_config
>>    drm/i915: Add 180 degree primary plane rotation support
>>    drm: Resetting rotation property
>>
>> Ville Syrjälä (3):
>>    drm/i915: Add 180 degree sprite rotation support
>>    drm/i915: Make intel_plane_restore() return an error
>>    drm/i915: Add rotation property for sprites
>
> Also, you forgot to bump the series version, it's really nice to have it
> to follow the progress (and later, to have tools do that for us).
>
Since this was a new patch set without the previous patches I thought it 
is not needed. Sure I will keep this in mind for the next time.

> I noticed you likely used --subject-prefix="v3" in the previous one,
> that's not quite how one is supposed to do it. The series versioning
> goes into the cover letter subject, and that's it.
>
I was not aware of this. I thought every patch has to have the version 
number. Thanks for pointing it out.
> Cheers,
>