* [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6
@ 2014-06-28 5:56 deepak.s
2014-07-15 7:33 ` Deepak S
0 siblings, 1 reply; 5+ messages in thread
From: deepak.s @ 2014-06-28 5:56 UTC (permalink / raw)
To: intel-gfx
From: Deepak S <deepak.s@linux.intel.com>
Drop WaGsvBringDownFreq on CHV.
When in RC6 requesting the min freq should be fine to bring the
voltage down.
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 6b6cfd4..4875f745 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3253,7 +3253,9 @@ void gen6_rps_idle(struct drm_i915_private *dev_priv)
mutex_lock(&dev_priv->rps.hw_lock);
if (dev_priv->rps.enabled) {
- if (IS_VALLEYVIEW(dev))
+ if (IS_CHERRYVIEW(dev))
+ valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
+ else if (IS_VALLEYVIEW(dev))
vlv_set_rps_idle(dev_priv);
else
gen6_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6
2014-07-15 7:33 ` Deepak S
@ 2014-07-14 15:17 ` Jesse Barnes
2014-07-14 17:27 ` Daniel Vetter
2014-07-16 3:21 ` Deepak S
0 siblings, 2 replies; 5+ messages in thread
From: Jesse Barnes @ 2014-07-14 15:17 UTC (permalink / raw)
To: Deepak S; +Cc: intel-gfx
On Tue, 15 Jul 2014 13:03:55 +0530
Deepak S <deepak.s@linux.intel.com> wrote:
>
> On Saturday 28 June 2014 11:26 AM, deepak.s@linux.intel.com wrote:
> > From: Deepak S <deepak.s@linux.intel.com>
> >
> > Drop WaGsvBringDownFreq on CHV.
> > When in RC6 requesting the min freq should be fine to bring the
> > voltage down.
> >
> > Signed-off-by: Deepak S <deepak.s@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_pm.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 6b6cfd4..4875f745 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -3253,7 +3253,9 @@ void gen6_rps_idle(struct drm_i915_private *dev_priv)
> >
> > mutex_lock(&dev_priv->rps.hw_lock);
> > if (dev_priv->rps.enabled) {
> > - if (IS_VALLEYVIEW(dev))
> > + if (IS_CHERRYVIEW(dev))
> > + valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
> > + else if (IS_VALLEYVIEW(dev))
> > vlv_set_rps_idle(dev_priv);
> > else
> > gen6_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
>
> Hi Jesse,
>
> can you please review this patch?
Reviewed-by: Jesse Barnes <jbarnes@Virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6
2014-07-14 15:17 ` Jesse Barnes
@ 2014-07-14 17:27 ` Daniel Vetter
2014-07-16 3:21 ` Deepak S
1 sibling, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2014-07-14 17:27 UTC (permalink / raw)
To: Jesse Barnes; +Cc: intel-gfx
On Mon, Jul 14, 2014 at 08:17:15AM -0700, Jesse Barnes wrote:
> On Tue, 15 Jul 2014 13:03:55 +0530
> Deepak S <deepak.s@linux.intel.com> wrote:
>
> >
> > On Saturday 28 June 2014 11:26 AM, deepak.s@linux.intel.com wrote:
> > > From: Deepak S <deepak.s@linux.intel.com>
> > >
> > > Drop WaGsvBringDownFreq on CHV.
> > > When in RC6 requesting the min freq should be fine to bring the
> > > voltage down.
> > >
> > > Signed-off-by: Deepak S <deepak.s@linux.intel.com>
> > > ---
> > > drivers/gpu/drm/i915/intel_pm.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > > index 6b6cfd4..4875f745 100644
> > > --- a/drivers/gpu/drm/i915/intel_pm.c
> > > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > > @@ -3253,7 +3253,9 @@ void gen6_rps_idle(struct drm_i915_private *dev_priv)
> > >
> > > mutex_lock(&dev_priv->rps.hw_lock);
> > > if (dev_priv->rps.enabled) {
> > > - if (IS_VALLEYVIEW(dev))
> > > + if (IS_CHERRYVIEW(dev))
> > > + valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
> > > + else if (IS_VALLEYVIEW(dev))
> > > vlv_set_rps_idle(dev_priv);
> > > else
> > > gen6_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
> >
> > Hi Jesse,
> >
> > can you please review this patch?
>
> Reviewed-by: Jesse Barnes <jbarnes@Virtuousgeek.org>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6
2014-06-28 5:56 [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6 deepak.s
@ 2014-07-15 7:33 ` Deepak S
2014-07-14 15:17 ` Jesse Barnes
0 siblings, 1 reply; 5+ messages in thread
From: Deepak S @ 2014-07-15 7:33 UTC (permalink / raw)
To: intel-gfx
On Saturday 28 June 2014 11:26 AM, deepak.s@linux.intel.com wrote:
> From: Deepak S <deepak.s@linux.intel.com>
>
> Drop WaGsvBringDownFreq on CHV.
> When in RC6 requesting the min freq should be fine to bring the
> voltage down.
>
> Signed-off-by: Deepak S <deepak.s@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 6b6cfd4..4875f745 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3253,7 +3253,9 @@ void gen6_rps_idle(struct drm_i915_private *dev_priv)
>
> mutex_lock(&dev_priv->rps.hw_lock);
> if (dev_priv->rps.enabled) {
> - if (IS_VALLEYVIEW(dev))
> + if (IS_CHERRYVIEW(dev))
> + valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
> + else if (IS_VALLEYVIEW(dev))
> vlv_set_rps_idle(dev_priv);
> else
> gen6_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
Hi Jesse,
can you please review this patch?
Thanks
Deepak
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6
2014-07-14 15:17 ` Jesse Barnes
2014-07-14 17:27 ` Daniel Vetter
@ 2014-07-16 3:21 ` Deepak S
1 sibling, 0 replies; 5+ messages in thread
From: Deepak S @ 2014-07-16 3:21 UTC (permalink / raw)
To: Jesse Barnes; +Cc: intel-gfx
On Monday 14 July 2014 08:47 PM, Jesse Barnes wrote:
> On Tue, 15 Jul 2014 13:03:55 +0530
> Deepak S <deepak.s@linux.intel.com> wrote:
>
>> On Saturday 28 June 2014 11:26 AM, deepak.s@linux.intel.com wrote:
>>> From: Deepak S <deepak.s@linux.intel.com>
>>>
>>> Drop WaGsvBringDownFreq on CHV.
>>> When in RC6 requesting the min freq should be fine to bring the
>>> voltage down.
>>>
>>> Signed-off-by: Deepak S <deepak.s@linux.intel.com>
>>> ---
>>> drivers/gpu/drm/i915/intel_pm.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>>> index 6b6cfd4..4875f745 100644
>>> --- a/drivers/gpu/drm/i915/intel_pm.c
>>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>>> @@ -3253,7 +3253,9 @@ void gen6_rps_idle(struct drm_i915_private *dev_priv)
>>>
>>> mutex_lock(&dev_priv->rps.hw_lock);
>>> if (dev_priv->rps.enabled) {
>>> - if (IS_VALLEYVIEW(dev))
>>> + if (IS_CHERRYVIEW(dev))
>>> + valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
>>> + else if (IS_VALLEYVIEW(dev))
>>> vlv_set_rps_idle(dev_priv);
>>> else
>>> gen6_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
>> Hi Jesse,
>>
>> can you please review this patch?
> Reviewed-by: Jesse Barnes <jbarnes@Virtuousgeek.org>
>
Thanks for reviewing
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-15 3:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-28 5:56 [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6 deepak.s
2014-07-15 7:33 ` Deepak S
2014-07-14 15:17 ` Jesse Barnes
2014-07-14 17:27 ` Daniel Vetter
2014-07-16 3:21 ` Deepak S
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox