Re: [PATCH v4] drm/i915: Force GPU Freq to lowest while suspending.

[Deepak S <deepak.s@linux.intel.com>]

On Monday 14 July 2014 08:47 PM, Jesse Barnes wrote:
> On Tue, 15 Jul 2014 13:05:48 +0530
> Deepak S <deepak.s@linux.intel.com> wrote:
>
>> On Friday 20 June 2014 08:03 PM, deepak.s@linux.intel.com wrote:
>>> From: Deepak S <deepak.s@linux.intel.com>
>>>
>>> We might be leaving the GPU Frequency (and thus vnn) high during the suspend.
>>> Force gt to move to lowest freq while suspending.
>>>
>>> v2: Fixed typo in commit message (Deepak)
>>>
>>> v3: Force gt to lowest freq in suspend_gt_powersave (Daniel)
>>>
>>> v4: Add GPU min freq set _after_ we've cancelled the rps works (Daniel)
>>>
>>> Signed-off-by: Deepak S <deepak.s@linux.intel.com>
>>> ---
>>>    drivers/gpu/drm/i915/intel_pm.c | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>>> index 2043c4b..0543407 100644
>>> --- a/drivers/gpu/drm/i915/intel_pm.c
>>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>>> @@ -4884,6 +4884,9 @@ void intel_suspend_gt_powersave(struct drm_device *dev)
>>>    	flush_delayed_work(&dev_priv->rps.delayed_resume_work);
>>>    
>>>    	cancel_work_sync(&dev_priv->rps.work);
>>> +
>>> +	/* Force GPU to min freq during suspend */
>>> +	gen6_rps_idle(dev_priv);
>>>    }
>>>    
>>>    void intel_disable_gt_powersave(struct drm_device *dev)
>> Hi Jesse,
>>
>> Please review the patch
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>

Thanks for reviewing