From mboxrd@z Thu Jan  1 00:00:00 1970
From: Deepak S <deepak.s@linux.intel.com>
Subject: Re: [PATCH v4] drm/i915: Force GPU Freq to lowest while
	suspending.
Date: Wed, 16 Jul 2014 08:51:47 +0530
Message-ID: <53C5EFCB.3030306@linux.intel.com>
References: <CAKMK7uE0q+nDdqcU19i5nxwxBuiDHaK7x+ji70A2PoF4jV+SPg@mail.gmail.com>	<1403274782-8437-1-git-send-email-deepak.s@linux.intel.com>	<53C4D9D4.2050808@linux.intel.com>
 <20140714081730.157d59a4@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 9CDBB6E4D1
 for <intel-gfx@lists.freedesktop.org>; Mon, 14 Jul 2014 20:27:01 -0700 (PDT)
In-Reply-To: <20140714081730.157d59a4@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org


On Monday 14 July 2014 08:47 PM, Jesse Barnes wrote:
> On Tue, 15 Jul 2014 13:05:48 +0530
> Deepak S <deepak.s@linux.intel.com> wrote:
>
>> On Friday 20 June 2014 08:03 PM, deepak.s@linux.intel.com wrote:
>>> From: Deepak S <deepak.s@linux.intel.com>
>>>
>>> We might be leaving the GPU Frequency (and thus vnn) high during the suspend.
>>> Force gt to move to lowest freq while suspending.
>>>
>>> v2: Fixed typo in commit message (Deepak)
>>>
>>> v3: Force gt to lowest freq in suspend_gt_powersave (Daniel)
>>>
>>> v4: Add GPU min freq set _after_ we've cancelled the rps works (Daniel)
>>>
>>> Signed-off-by: Deepak S <deepak.s@linux.intel.com>
>>> ---
>>>    drivers/gpu/drm/i915/intel_pm.c | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>>> index 2043c4b..0543407 100644
>>> --- a/drivers/gpu/drm/i915/intel_pm.c
>>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>>> @@ -4884,6 +4884,9 @@ void intel_suspend_gt_powersave(struct drm_device *dev)
>>>    	flush_delayed_work(&dev_priv->rps.delayed_resume_work);
>>>    
>>>    	cancel_work_sync(&dev_priv->rps.work);
>>> +
>>> +	/* Force GPU to min freq during suspend */
>>> +	gen6_rps_idle(dev_priv);
>>>    }
>>>    
>>>    void intel_disable_gt_powersave(struct drm_device *dev)
>> Hi Jesse,
>>
>> Please review the patch
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>

Thanks for reviewing