public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: "Gore, Tim" <tim.gore@intel.com>,
	Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Intel-gfx@lists.freedesktop.org" <Intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] tests/gem_userptr_blits: Race between object creation and multi-threaded mm ops
Date: Fri, 18 Jul 2014 10:36:15 +0100	[thread overview]
Message-ID: <53C8EA8F.3080702@linux.intel.com> (raw)
In-Reply-To: <8FCC70911F3E9548866CA0E51893BCC31A1D28A1@IRSMSX105.ger.corp.intel.com>


On 07/18/2014 10:20 AM, Gore, Tim wrote:
> Unfortunately Android threads do not support cancel and testcancel, so this
> Test cannot build for android.
> Do we really need a cancellation point, since we don't need to cancel the thread.
> Tvrtko's original solution seemed workable, if a bit less polished.

Solution with a flag is fine in my opinion, but I also need to get rid 
of asserts in the thread. This is was Chris was pointing out, I always 
forget that threads have too much independence so SIGBART in a thread 
won't kill the process. I've put it on my TODO for the lower priority 
tasks, since I would still like to propagate any failures in the thread 
to subtest fail.

Tvrtko

  reply	other threads:[~2014-07-18  9:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 10:03 [PATCH] tests/gem_userptr_blits: Race between object creation and multi-threaded mm ops Tvrtko Ursulin
2014-07-14 10:34 ` Chris Wilson
2014-07-14 10:44   ` Tvrtko Ursulin
2014-07-14 13:07     ` Chris Wilson
2014-07-14 13:13       ` Tvrtko Ursulin
2014-07-14 13:27         ` Chris Wilson
2014-07-18  9:20           ` Gore, Tim
2014-07-18  9:36             ` Tvrtko Ursulin [this message]
2014-07-14 13:19 ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C8EA8F.3080702@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=tim.gore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox