From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
Subject: Re: [RFC v2 2/3] drm/i915: duplicate
 i915_gem_ring_dispatch trace and add ctx parameter
Date: Fri, 18 Jul 2014 10:43:36 +0100
Message-ID: <53C8EC48.3030806@intel.com>
References: <1405527759-957-1-git-send-email-daniele.ceraolospurio@intel.com>
 <1405527759-957-3-git-send-email-daniele.ceraolospurio@intel.com>
 <20140717162504.GB3452@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 7BC2F6E750
 for <intel-gfx@lists.freedesktop.org>; Fri, 18 Jul 2014 02:43:38 -0700 (PDT)
In-Reply-To: <20140717162504.GB3452@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 7/17/2014 5:25 PM, Chris Wilson wrote:
> On Wed, Jul 16, 2014 at 05:22:38PM +0100, daniele.ceraolospurio@intel.com wrote:
>> From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>>
>> The context used to execute a batchbuffer is becoming increasingly
>> important. Duplicating to avoid modifications to the original trace.
>
> I am sure we don't want both. The structure encoding is exposed to
> userspace so we are free to update the tracepoints within reason.

As you can see by the next patch in the series, I plan to add a callback 
inside the trace. My original patch modified the existing trace, but (if 
I've understood correctly) Daniel asked for a duplicated trace to avoid 
adding the callback into the existing one.

> I would also like a better ctx identifier than its pointer. Using the
> pointer for tracking objects makes it more difficult to read traces
> (although it is easy for scripts).

I use the VM pointer to track the ppgtt; that pointer is also printed by 
several other traces, including the ppgtt init/release ones that I've 
submitted for comments in this series. However, I don't mind changing 
the way we identify the ctx as long as I still have access to the VM 
pointer. I'll have a look at the possible ways of identifying the ctx 
and I'll try to find a better solution than the current one.

thanks,
Daniele