From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jindal, Sonika" <sonika.jindal@intel.com>
Subject: Re: [PATCH 0/7] Future preparation patches
Date: Mon, 21 Jul 2014 11:16:27 +0530
Message-ID: <53CCA933.4030704@intel.com>
References: <1405661650-5771-1-git-send-email-sonika.jindal@intel.com>
 <20140718105616.GB31263@strange.amr.corp.intel.com>
 <53C903B6.3060608@intel.com>
 <20140718130456.GC32442@strange.amr.corp.intel.com>
 <20140718133004.GR15237@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id E326189D66
 for <intel-gfx@lists.freedesktop.org>; Sun, 20 Jul 2014 22:46:30 -0700 (PDT)
In-Reply-To: <20140718133004.GR15237@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>, Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org



On 7/18/2014 7:00 PM, Daniel Vetter wrote:
> On Fri, Jul 18, 2014 at 02:04:56PM +0100, Damien Lespiau wrote:
>> On Fri, Jul 18, 2014 at 04:53:34PM +0530, Jindal, Sonika wrote:
>>>
>>>
>>> On 7/18/2014 4:26 PM, Damien Lespiau wrote:
>>>> On Fri, Jul 18, 2014 at 11:04:03AM +0530, sonika.jindal@intel.com wrote:
>>>>> From: Sonika Jindal <sonika.jindal@intel.com>
>>>>>
>>>>> This series prepares future platform enabling by changing HAS_PCH_SPLIT to more
>>>>> appropriate check since the code accessed may not have anything to do with
>>>>> having PCH or not.
>>>>
>>>> Hi Sonika,
>>>>
>>>> HAS_PCH_SPLIT() is true for Ironlake (gen 5) as it's paired with the
>>>> Ibex Peak PCH.
>>>>
>>>> In various patches, the condition needs to be INTEL_INFO(dev)->gen < 5
>>>> then.
>>>>
>>> I am sorry, my understanding was that HAS_PCH_SPLIT is equivalent to
>>> (gen > 5 && !(IS_VALLEYVIEW) )
>>> So, is it like, HAS_PCH_SPLIT is equivalent to (gen >=5 && !(IS_VALEYVIEW))
>>
>> Yes, indeed!
>
> Since the patches need to be respun anyway, I vote for the introduction of
> HAS_GMCH_DISPLAY for the gen < 5 || IS_VLV condition. Since vlv (i.e. byt
> + chv) have essentially inherited the gmch display block from gen3/4. I
> think that would help the readability of the code quite a bit.
>
> Comments?
> -Daniel
>
Ok, I will add this and send the patches again.

-Sonika