public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: jani.nikula@intel.com
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	Bertrik Sikken <bertrik@sikken.nl>
Subject: [REGRESSION BISECTED] backlight control stops workin with 3.14 and later
Date: Tue, 22 Jul 2014 08:42:33 +0200	[thread overview]
Message-ID: <53CE07D9.3090308@redhat.com> (raw)

Hi Jani et al,

A friend of mine Bertrik Sikken (in the Cc) his backlight control
stopped working for him on his Samsung N150Plus netbook.

I took a quick look, and the raw intel_backlight backlight interface
works under 3.14, but the firmware samsung_laptop backlight interface,
which is what most userspace apps will use by default, stops working
in 3.14 .

I've asked him to bisect this and the bisect points out this
commit as the culprit:

b35684b8fa94e04f55fd38bf672b737741d2f9e2 is the first bad commit
commit b35684b8fa94e04f55fd38bf672b737741d2f9e2
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Thu Nov 14 12:13:41 2013 +0200

    drm/i915: do full backlight setup at enable time

    We should now have all the information we need to do a full
    initialization of the backlight registers.

    v2: Keep QUIRK_NO_PCH_PWM_ENABLE for now (Imre).

    Signed-off-by: Jani Nikula <jani.nikula@intel.com>
    Reviewed-by: Imre Deak <imre.deak@intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Note that this laptop has an acpi_video backlight interface too,
but that has been broken from the start and gets disabled by
samsung-laptop based on dmi matching.

Regards,

Hans

             reply	other threads:[~2014-07-22  6:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22  6:42 Hans de Goede [this message]
2014-07-22  6:52 ` [REGRESSION BISECTED] backlight control stops workin with 3.14 and later Daniel Vetter
2014-07-22  6:59   ` Chris Wilson
2014-07-23  8:46   ` Hans de Goede
2014-07-23 13:15     ` Bertrik Sikken
2014-08-13 13:43     ` Jani Nikula
2014-08-14 19:45       ` Bertrik Sikken
2014-08-15 13:43         ` Jani Nikula
2014-08-17  8:44           ` Bertrik Sikken
2014-08-18  7:37             ` Jani Nikula
2014-08-19  9:52               ` Bertrik Sikken
2014-08-19 13:29                 ` Jani Nikula
2014-08-21 21:44                   ` Bertrik Sikken
2014-08-22  6:48                     ` Jani Nikula
2014-08-22 10:52                       ` Bertrik Sikken
2014-08-23 13:11                       ` Hans de Goede
2014-08-25  7:29                         ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CE07D9.3090308@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=bertrik@sikken.nl \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox