From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hans de Goede <hdegoede@redhat.com>
Subject: [REGRESSION BISECTED] backlight control stops workin
 with 3.14 and later
Date: Tue, 22 Jul 2014 08:42:33 +0200
Message-ID: <53CE07D9.3090308@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by gabe.freedesktop.org (Postfix) with ESMTP id 714B06E49D
 for <intel-gfx@lists.freedesktop.org>; Mon, 21 Jul 2014 23:42:38 -0700 (PDT)
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: jani.nikula@intel.com
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, Bertrik Sikken <bertrik@sikken.nl>
List-Id: intel-gfx@lists.freedesktop.org

Hi Jani et al,

A friend of mine Bertrik Sikken (in the Cc) his backlight control
stopped working for him on his Samsung N150Plus netbook.

I took a quick look, and the raw intel_backlight backlight interface
works under 3.14, but the firmware samsung_laptop backlight interface,
which is what most userspace apps will use by default, stops working
in 3.14 .

I've asked him to bisect this and the bisect points out this
commit as the culprit:

b35684b8fa94e04f55fd38bf672b737741d2f9e2 is the first bad commit
commit b35684b8fa94e04f55fd38bf672b737741d2f9e2
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Thu Nov 14 12:13:41 2013 +0200

    drm/i915: do full backlight setup at enable time

    We should now have all the information we need to do a full
    initialization of the backlight registers.

    v2: Keep QUIRK_NO_PCH_PWM_ENABLE for now (Imre).

    Signed-off-by: Jani Nikula <jani.nikula@intel.com>
    Reviewed-by: Imre Deak <imre.deak@intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Note that this laptop has an acpi_video backlight interface too,
but that has been broken from the start and gets disabled by
samsung-laptop based on dmi matching.

Regards,

Hans