Re: [RFC 18/44] drm/i915: Added scheduler debug macro

Jesse Barnes
2014-07-02T18:36:44Z

On Thu, 26 Jun 2014 18:24:09 +0100
John.C.Harrison@Intel.com wrote:

> From: John Harrison <John.C.Harrison@Intel.com>
>
> Added a DRM debug facility for use by the scheduler.
> ---
> include/drm/drmP.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> index 76ccaab..2f477c9 100644
> --- a/include/drm/drmP.h
> +++ b/include/drm/drmP.h
> @@ -120,6 +120,7 @@ struct videomode;
> #define DRM_UT_DRIVER 0x02
> #define DRM_UT_KMS 0x04
> #define DRM_UT_PRIME 0x08
> +#define DRM_UT_SCHED 0x40

What's wrong with 0x10? We should probably define these in terms of
shifts anyway, since this is just a bitmask really.

> extern __printf(2, 3)
> void drm_ut_debug_printk(const char *function_name,
> @@ -221,10 +222,16 @@ int drm_err(const char *func, const char *format, ...);
> if (unlikely(drm_debug & DRM_UT_PRIME)) \
> drm_ut_debug_printk(__func__, fmt, ##args); \
> } while (0)
> +#define DRM_DEBUG_SCHED(fmt, args...) \
> + do { \
> + if (unlikely(drm_debug & DRM_UT_SCHED)) \
> + drm_ut_debug_printk(__func__, fmt, ##args); \
> + } while (0)
> #else
> #define DRM_DEBUG_DRIVER(fmt, args...) do { } while (0)
> #define DRM_DEBUG_KMS(fmt, args...) do { } while (0)
> #define DRM_DEBUG_PRIME(fmt, args...) do { } while (0)
> +#define DRM_DEBUG_SCHED(fmt, args...) do { } while (0)
> #define DRM_DEBUG(fmt, arg...) do { } while (0)
> #endif
>

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

--
Jesse Barnes, Intel Open Source Technology Center