Re: [RFC 11/44] drm/i915: Added scheduler hook into i915_seqno_passed()

Jesse Barnes
2014-07-02T18:13:51Z

On Thu, 26 Jun 2014 18:24:02 +0100
John.C.Harrison@Intel.com wrote:

> +bool i915_scheduler_is_seqno_in_flight(struct intel_engine_cs *ring,
> + uint32_t seqno, bool *completed);
> +

In what cases might the return value not match the completed value? I
guess I'll see in a later patch...

Same comment about the ifdef applies here; looks like you have some
runtime checking in place too, which seems sufficient to me.

--
Jesse Barnes, Intel Open Source Technology Center