From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sun, Daisy" Subject: Re: [PATCH v2] drm/i915/bdw: BDW Software Turbo Date: Fri, 25 Jul 2014 08:51:13 -0700 Message-ID: <53D27CF1.9030209@intel.com> References: <20140710083238.GK8986@nuc-i3427.alporthouse.com> <53BEDEB3.2000003@intel.com> <20140710190754.GN8986@nuc-i3427.alporthouse.com> <53BF4E64.2040802@intel.com> <20140711061554.GR8986@nuc-i3427.alporthouse.com> <20140714065940.GB15237@phenom.ffwll.local> <20140724132821.3fcb14ff@jbarnes-desktop> <20140725072210.GF4747@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F81B6E058 for ; Fri, 25 Jul 2014 08:51:15 -0700 (PDT) In-Reply-To: <20140725072210.GF4747@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Jesse Barnes Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org Yes, timer can be helpful. A revised proposal is that flip trigger + timer to cover together. I'll come up with more details soon. - Daisy On 7/25/2014 12:22 AM, Daniel Vetter wrote: > On Thu, Jul 24, 2014 at 01:28:21PM -0700, Jesse Barnes wrote: >> If that won't work, you could just use a timer, or tie into some other >> event that happens when the GPU is busy (e.g. execbuf or retire) instead >> of trying to tie into the display side of things. > Yes, tying into a normal timer is probably best. At least I get the > impression that we only need something regular. Of course once the gpu is > idle we need to stop rearming that timer and restart it upon first batch > when transitioning out of idle. > -Daniel > >> Jesse >> >> On Tue, 15 Jul 2014 06:35:20 +0000 >> "Sun, Daisy" wrote: >> >>> Hi Daniel, Chris >>> >>> The concern for traditional X and media server do make sense. I'll update the patch with RP_UP_EI_INTERRUPT as trigger instead of the page flip. >>> Thanks for the valuable input. >>> >>> - Daisy >>> >>> -----Original Message----- >>> From: daniel.vetter@ffwll.ch [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter >>> Sent: Monday, July 14, 2014 12:04 AM >>> To: Sun, Daisy >>> Cc: Chris Wilson; intel-gfx@lists.freedesktop.org >>> Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo >>> >>> On Mon, Jul 14, 2014 at 8:59 AM, Daniel Vetter wrote: >>>> On Mon, Jul 14, 2014 at 04:22:44AM +0000, Sun, Daisy wrote: >>>>> 3) The function will be called when flip happened, this should cover >>>>> most of the cases. One exception is background media process without >>>>> any display output, it's relatively rare. Please let me know if you >>>>> have concern on other cases, I will try to cover it definitely. >>>> Traditional X never flips. And we kinda have to keep this working. >>>> Instead of checking when flipping we need to check at regular time >>>> intervals I guess, for as long as the gt is busy. >>> Oh and transcode servers are a real thing apparently. They also never flip, and we actually care from a business pov ... >>> -Daniel >>> -- >>> Daniel Vetter >>> Software Engineer, Intel Corporation >>> +41 (0) 79 365 57 48 - http://blog.ffwll.ch >>> _______________________________________________ >>> Intel-gfx mailing list >>> Intel-gfx@lists.freedesktop.org >>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx >>> >> >> -- >> Jesse Barnes, Intel Open Source Technology Center