From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
Subject: Re: [RFC v2 2/3] drm/i915: duplicate
 i915_gem_ring_dispatch trace and add ctx parameter
Date: Wed, 30 Jul 2014 13:34:44 +0100
Message-ID: <53D8E664.8050004@intel.com>
References: <1405527759-957-1-git-send-email-daniele.ceraolospurio@intel.com>
 <1405527759-957-3-git-send-email-daniele.ceraolospurio@intel.com>
 <20140717162504.GB3452@nuc-i3427.alporthouse.com>
 <53C8EC48.3030806@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id C1FF76E5D4
 for <intel-gfx@lists.freedesktop.org>; Wed, 30 Jul 2014 05:34:51 -0700 (PDT)
In-Reply-To: <53C8EC48.3030806@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

>> I would also like a better ctx identifier than its pointer. Using the
>> pointer for tracking objects makes it more difficult to read traces
>> (although it is easy for scripts).
>
> I use the VM pointer to track the ppgtt; that pointer is also printed by
> several other traces, including the ppgtt init/release ones that I've
> submitted for comments in this series. However, I don't mind changing
> the way we identify the ctx as long as I still have access to the VM
> pointer. I'll have a look at the possible ways of identifying the ctx
> and I'll try to find a better solution than the current one.
>

I've looked for other ways to identify the ctx, but I could't find 
anything more readable than a pointer. The best alternative in my 
opinion is to use the user_handle, but that is dependent on the 
file_priv so it is not enough on its own. Coupling the user_handle with 
the file_priv pointer doesn't seem like a good idea, so I still think 
that using the ctx pointer or the vm pointer is the best way to identify 
the ctx at the moment. Did you have something in mind that I've missed?

Thanks,
Daniele