From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jindal, Sonika" Subject: Re: [PATCH 6/6] drm: Resetting rotation property Date: Mon, 04 Aug 2014 17:33:43 +0530 Message-ID: <53DF769F.7070607@intel.com> References: <1405413629-4266-1-git-send-email-sonika.jindal@intel.com> <1405413629-4266-7-git-send-email-sonika.jindal@intel.com> <20140804120154.GE4193@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 41E0D6E3AE for ; Mon, 4 Aug 2014 05:03:46 -0700 (PDT) In-Reply-To: <20140804120154.GE4193@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?ISO-8859-1?Q?Ville_Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 8/4/2014 5:31 PM, Ville Syrj=E4l=E4 wrote: > On Tue, Jul 15, 2014 at 02:10:29PM +0530, sonika.jindal@intel.com wrote: >> From: Sonika Jindal >> >> Reset rotation property to 0 wherever applicable >> >> Signed-off-by: Sonika Jindal >> --- >> drivers/gpu/drm/drm_fb_helper.c | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_he= lper.c >> index 3144db9..961afcb 100644 >> --- a/drivers/gpu/drm/drm_fb_helper.c >> +++ b/drivers/gpu/drm/drm_fb_helper.c >> @@ -345,9 +345,17 @@ static bool restore_fbdev_mode(struct drm_fb_helper= *fb_helper) >> >> drm_warn_on_modeset_not_all_locked(dev); >> >> - list_for_each_entry(plane, &dev->mode_config.plane_list, head) >> + list_for_each_entry(plane, &dev->mode_config.plane_list, head) { >> + >> + if (dev->mode_config.rotation_property) { >> + drm_object_property_set_value(&plane->base, >> + dev->mode_config.rotation_property, >> + BIT(DRM_ROTATE_0)); >> + } >> + >> if (plane->type !=3D DRM_PLANE_TYPE_PRIMARY) >> drm_plane_force_disable(plane); > > I would reset the property after disabling the plane. Ok, I will change that. > >> + } >> >> for (i =3D 0; i < fb_helper->crtc_count; i++) { >> struct drm_mode_set *mode_set =3D &fb_helper->crtc_info[i].mode_set; >> -- >> 1.7.10.4 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx >