From mboxrd@z Thu Jan 1 00:00:00 1970 From: Clint Taylor Subject: Re: [PATCH] drm/i915: remove pixel doubled HDMI modes from valid modes list Date: Tue, 12 Aug 2014 10:11:59 -0700 Message-ID: <53EA4ADF.2030804@intel.com> References: <1407796382-6168-1-git-send-email-clinton.a.taylor@intel.com> <20140812063924.GK6666@nuc-i3427.alporthouse.com> <20140812065944.GJ10500@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 962566E4FE for ; Tue, 12 Aug 2014 10:13:30 -0700 (PDT) In-Reply-To: <20140812065944.GJ10500@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Chris Wilson , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 08/11/2014 11:59 PM, Daniel Vetter wrote: > On Tue, Aug 12, 2014 at 07:39:24AM +0100, Chris Wilson wrote: >> On Mon, Aug 11, 2014 at 03:33:02PM -0700, clinton.a.taylor@intel.com wrote: >>> From: Clint Taylor >>> >>> Intel HDMI does not correctly configure pixel replicated HDMI modes >>> 480i and 576i. Remove support for these modes until DRM has been >>> changed to correctly identify SD interlaced modes by reporting there >>> true horizontal resolution 720 instead of the pre-pixel doubled 1440. >>> >>> Signed-off-by: Clint Taylor >>> --- >>> drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c >>> index 5f47d35..ab32523 100644 >>> --- a/drivers/gpu/drm/i915/intel_hdmi.c >>> +++ b/drivers/gpu/drm/i915/intel_hdmi.c >>> @@ -873,6 +873,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector, >>> if (mode->flags & DRM_MODE_FLAG_DBLSCAN) >>> return MODE_NO_DBLESCAN; >>> >> >> If it is just a workaround for a drm bug. You need a big comment >> explaining why you w/a rather than pressing for the bug fix. > > Well there's a very small chance I'll take this anyway - if the drm core > is broken we need to take out the mode from the drm core, not here. > -Daniel > Agreed this is not the correct solution to fix the issue. Advertising that we support bad geometry is also incorrect. Clint