From mboxrd@z Thu Jan 1 00:00:00 1970 From: Clint Taylor Subject: Re: [PATCH 0/4] drm/i915: backlight sysfs bl_power and brightness == 0 Date: Wed, 13 Aug 2014 18:11:39 -0700 Message-ID: <53EC0CCB.2030305@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F3A9898C2 for ; Wed, 13 Aug 2014 18:13:00 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , intel-gfx@lists.freedesktop.org Cc: rodrigo.vivi@intel.com, kevin.strasser@intel.com, jesse.barnes@intel.com List-Id: intel-gfx@lists.freedesktop.org On 08/12/2014 07:11 AM, Jani Nikula wrote: > This series adds support for backlight class sysfs bl_power attribute > for eDP panels, which allows switching the backlight on/off. This is > done using the eDP panel power control as a sub-state of everything else > being enabled. Patch 4 also makes 0 brightness switch off the eDP > backlight using the same mechanism. This is all eDP specific, with no > support for LVDS. > > I'm not particularly fond of these patches, but there appears to be > demand for them, particularly since > > commit 6dda730e55f412a6dfb181cae6784822ba463847 > Author: Jani Nikula > Date: Tue Jun 24 18:27:40 2014 +0300 > > drm/i915: respect the VBT minimum backlight brightness > > All the discussions seem to just drag on and on without code to speak > about, so here goes. I've tried to make this as simple and unintrusive > as possible. > > BR, > Jani. > I have hand merged the first 3 patches of this series into kernel 3.10 Chromium and the bl_power sysfs entry is functional and turns off backlight power independent of the PWM as designed. The fourth patch is non-functional due to the difference between the 11 Chromium backlight patches from April 2014 and current upstream implementation. Clint > > Jani Nikula (4): > drm/i915/dp: split up panel power control from backlight pwm control > drm/i915: add some framework for backlight bl_power support > drm/i915/dp: make backlight bl_power control power sequencer backlight > drm/i915: switch off backlight for backlight class 0 brightness > > drivers/gpu/drm/i915/intel_dp.c | 61 ++++++++++++++++++++++++++++++-------- > drivers/gpu/drm/i915/intel_drv.h | 2 ++ > drivers/gpu/drm/i915/intel_panel.c | 27 +++++++++++++++++ > 3 files changed, 77 insertions(+), 13 deletions(-) >