Re: [PATCH 08/16] drm/i915: Don't call DVO mode_set hook on DPMS changes

Thomas Richter
2014-08-15T13:30:48Z

On 15.08.2014 00:22, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Calling the mode_set hook on DPMS changes doesn't seem to be necessary
> for ns2501. Just drop it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Tested-by: Thomas Richter <richter@rus.uni-stuttgart.de>

> ---
> drivers/gpu/drm/i915/intel_dvo.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/intel_dvo.c
> index 4f115c1..e40e3df 100644
> --- a/drivers/gpu/drm/i915/intel_dvo.c
> +++ b/drivers/gpu/drm/i915/intel_dvo.c
> @@ -227,10 +227,6 @@ static void intel_dvo_dpms(struct drm_connector *connector, int mode)
>
> intel_crtc_update_dpms(crtc);
>
> - intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
> - &config->requested_mode,
> - &config->adjusted_mode);
> -
> intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
> } else {
> intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);