From mboxrd@z Thu Jan 1 00:00:00 1970 From: Clint Taylor Subject: Re: [PATCH 4/4] drm/i915: switch off backlight for backlight class 0 brightness Date: Tue, 19 Aug 2014 16:04:50 -0700 Message-ID: <53F3D812.1050800@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A7706E66E for ; Tue, 19 Aug 2014 16:05:51 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , intel-gfx@lists.freedesktop.org Cc: rodrigo.vivi@intel.com, kevin.strasser@intel.com, jesse.barnes@intel.com List-Id: intel-gfx@lists.freedesktop.org On 08/12/2014 07:11 AM, Jani Nikula wrote: > Make backlight class sysfs brightness 0 value switch off the backlight > for connectors that have the backlight_power callback defined. For eDP, > this has the similar caveats regarding power savings as bl_power as only > the power sequencer backlight control is switched off. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_panel.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c > index c365f2a57c75..574690afadb3 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -986,7 +986,8 @@ static int intel_backlight_device_update_status(struct backlight_device *bd) > */ > if (panel->backlight.enabled) { > if (panel->backlight_power) { > - bool enable = bd->props.power == FB_BLANK_UNBLANK; > + bool enable = bd->props.power == FB_BLANK_UNBLANK && > + bd->props.brightness != 0; > panel->backlight_power(connector, enable); > } > } else { > Didn't get a chance to test this on nightly. Reviewed_by: Clinton Taylor