From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Siluvery, Arun" Subject: Re: [PATCH] drm/i915/bdw: Render moot context reset and switch with Execlists Date: Tue, 26 Aug 2014 14:54:39 +0100 Message-ID: <53FC919F.3070702@linux.intel.com> References: <1406217891-8912-12-git-send-email-thomas.daniel@intel.com> <1408548564-3787-1-git-send-email-thomas.daniel@intel.com> <20140820153605.GE12830@nuc-i3427.alporthouse.com> <20140825203939.GK15520@phenom.ffwll.local> <20140826055947.GA20222@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id BB5306E1C4 for ; Tue, 26 Aug 2014 06:54:42 -0700 (PDT) In-Reply-To: <20140826055947.GA20222@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 26/08/2014 06:59, Chris Wilson wrote: > On Mon, Aug 25, 2014 at 10:39:39PM +0200, Daniel Vetter wrote: >> On Wed, Aug 20, 2014 at 04:36:05PM +0100, Chris Wilson wrote: >>> On Wed, Aug 20, 2014 at 04:29:24PM +0100, Thomas Daniel wrote: >>>> These two functions make no sense in an Logical Ring Context & Execlists >>>> world. >>>> >>>> v2: We got rid of lrc_enabled and centralized everything in the sanitized >>>> i915.enable_execlists instead. >>>> >>>> Signed-off-by: Oscar Mateo >>>> >>>> v3: Rebased. Corrected a typo in comment for i915_switch_context and >>>> added a comment that it should not be called in execlist mode. Added >>>> WARN_ON if i915_switch_context is called in execlist mode. Moved check >>>> for execlist mode out of i915_switch_context and into callers. Added >>>> comment in context_reset explaining why nothing is done in execlist >>>> mode. >>> >>> No, this is not the way. The requirement is to reduce the number of >>> special cases not increase them. These should be evaluated to be no-ops >>> when execlists is used. >> >> I think it's ok-ish for now. Maybe we need to reconsider when we wire up >> lrc reclaim - which is the real user of the switch_context in gpu_idle. >> The problem I have though is that I can't parse the subject of the patch, >> someone please translate that to simplified English for me. I can do the >> replacement while applying. > > No, it is not. execlists is badly designed and this is a further symptom > of that. > -Chris > Thomas is not available and I am replying on his behalf. Is the following subject is good for this patch? "Don't execute context reset and switch when using Execlists" regards Arun