From: Deepak S <deepak.s@intel.com>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv
Date: Sun, 31 Aug 2014 11:48:53 +0530 [thread overview]
Message-ID: <5402BE4D.9060200@intel.com> (raw)
In-Reply-To: <1409310847-24105-1-git-send-email-ville.syrjala@linux.intel.com>
On Friday 29 August 2014 04:44 PM, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> WaGsvRC0ResidenncyMethod is for vlv, it doesn't deal with chv
> appropriately (eg. doesn't limit rps values to even numbers).
>
> Fix a typo in the w/a name while at it.
>
> Cc: Deepak S <deepak.s@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 8a54870..6d5ae82 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -4692,8 +4692,8 @@ void intel_irq_init(struct drm_device *dev)
> INIT_WORK(&dev_priv->l3_parity.error_work, ivybridge_parity_work);
>
> /* Let's track the enabled rps events */
> - if (IS_VALLEYVIEW(dev))
> - /* WaGsvRC0ResidenncyMethod:VLV */
> + if (IS_VALLEYVIEW(dev) && !IS_CHERRYVIEW(dev))
> + /* WaGsvRC0ResidencyMethod:vlv */
> dev_priv->pm_rps_events = GEN6_PM_RP_UP_EI_EXPIRED;
> else
> dev_priv->pm_rps_events = GEN6_PM_RPS_EVENTS;
>
Reviewed-by: Deepak S <deepak.s@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-08-30 6:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 11:14 [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv ville.syrjala
2014-08-29 11:21 ` Chris Wilson
2014-08-29 12:09 ` Ville Syrjälä
2014-08-29 12:51 ` Chris Wilson
2014-08-29 13:01 ` Ville Syrjälä
2014-09-02 2:35 ` Deepak S
2014-08-31 6:18 ` Deepak S [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5402BE4D.9060200@intel.com \
--to=deepak.s@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox