Re: [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv

Chris Wilson
2014-08-29T12:51:10Z

On Fri, Aug 29, 2014 at 03:09:49PM +0300, Ville Syrjälä wrote:
> On Fri, Aug 29, 2014 at 12:21:27PM +0100, Chris Wilson wrote:
> > On Fri, Aug 29, 2014 at 02:14:07PM +0300, ville.syrjala@linux.intel.com wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > WaGsvRC0ResidenncyMethod is for vlv, it doesn't deal with chv
> > > appropriately (eg. doesn't limit rps values to even numbers).
> > >
> > > Fix a typo in the w/a name while at it.
> >
> > You could review my changes for the vlv manual calculations that would
> > fix it for chv as well...
>
> IIRC I glanced at them but there was too much noise in some of the
> patches for my poor brain so I gave up.

Could you clarify whether you mean WaGsvRC0ResidenncyMethod is only
intended for vlv (fixed for chv), or whether just the implementation is
currently only for chv.

If the former, and the code is no longer required,
Reviewed-by: Chris Wilson <chris@chris-wilson.o.uk>
-Chris

--
Chris Wilson, Intel Open Source Technology Centre